You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/22 07:24:16 UTC
[GitHub] [pulsar] TakaHiR07 opened a new issue, #16732: enhance enable bookkeeperClientExposeStatsToPrometheus would drop pulsar performance
TakaHiR07 opened a new issue, #16732:
URL: https://github.com/apache/pulsar/issues/16732
**Is your enhancement request related to a problem? Please describe.**
https://github.com/apache/pulsar/pull/16219, this pr fix the bug if bookkeeperClientExposeStatsToPrometheus is true. But after enable bookie client metrics, I found that it would generate too much prometheus metrics, which obviously drop pulsar performance.
As shown in the screenshot，pulsar_managedLedger_client metrics have 19473 lines, among them 18512 lines are per_channel_bookie_client metrics.
Actually, some metrics such as pulsar_managedLedger_client_BookKeeperClientWorker, pulsar_managedLedger_client_bookkeeper_client_ADD_ENTRY are useful for us and need to be opened. But the amount of per_channel_bookie_client metrics are usually not useful.
**Describe the solution you'd like**
Therefore, I think we should add a configuration to limit the per_channel_bookie_client metrics when we enable bookkeeperClientExposeStatsToPrometheus.
And I notice that in bookkeeper, a conf "limitStatsLogging" can limit those metrics, which
was proposed in this pr, https://github.com/apache/bookkeeper/pull/1888.
We should also add this conf in pulsar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #16732: enhance enable bookkeeperClientExposeStatsToPrometheus would drop pulsar performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #16732:
URL: https://github.com/apache/pulsar/issues/16732#issuecomment-1221710486
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #16732: enhance enable bookkeeperClientExposeStatsToPrometheus would drop pulsar performance
Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #16732: enhance enable bookkeeperClientExposeStatsToPrometheus would drop pulsar performance
URL: https://github.com/apache/pulsar/issues/16732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org