You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/03/04 21:10:06 UTC
[GitHub] [nifi] mtien-apache commented on pull request #5743: NIFI-8899 - Add NiFi Registry version information to the Registry under an "about" button.
mtien-apache commented on pull request #5743:
URL: https://github.com/apache/nifi/pull/5743#issuecomment-1059532629
@ohnoitsyou Thanks for the updates! Unfortunately I found a few other things.
- When I click on the info icon, the circle is off-center from the icon. It should look more like the wrench settings icon when clicked.
- In the dialog, the different states of the Close button style looks different than other buttons in the app. NiFi Registry follows the [NiFi Flow Design System (FDS)](https://nifi.apache.org/fds.html) for all of its style conventions. Specifically it has a `FdsDialogService` component you can leverage. An example of a similar button can be seen in the New Bucket dialog's Cancel button.
<img width="415" alt="4-about-dialog" src="https://user-images.githubusercontent.com/56892372/156840235-5272f5d4-f0b9-42f1-9c6d-ace784adb29a.png">
Button state when it's clicked on:
<img width="265" alt="5-close-dialog" src="https://user-images.githubusercontent.com/56892372/156840521-4c9e2163-e15c-40db-92c7-4b35a6558433.png">
- The info icon vertical alignment looks off from the question mark and wrench icons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org