You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "trns1997 (via GitHub)" <gi...@apache.org> on 2023/09/08 16:17:32 UTC
[GitHub] [nuttx] trns1997 opened a new pull request, #10553: fix led panic feature
trns1997 opened a new pull request, #10553:
URL: https://github.com/apache/nuttx/pull/10553
## Summary
- Fix LED PANIC Feature to blink at 2Hz.
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10553: fix led panic feature
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#discussion_r1325420577
##########
arch/arm/src/a1x/a1x_lowputc.c:
##########
@@ -27,13 +27,15 @@
#include <stdint.h>
#include <arch/irq.h>
-#include <arch/board/board.h>
#include "arm_internal.h"
#include "a1x_config.h"
-#include "hardware/a1x_uart.h"
#include "a1x_pio.h"
+#include "hardware/a1x_uart.h"
+
+#include <arch/board/board.h>
Review Comment:
normally, <> inclusion puts before "" inclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #10553: fix led panic feature
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#issuecomment-1713806682
@patacongo could you give some suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #10553: fix led panic feature
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#issuecomment-1712526478
Please also include a Summary and commit message explaining what you want to fix exactly.
As I told you, Panic LED is working, but your board needs to include the files needed to support it. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10553: fix led panic feature
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#discussion_r1320742731
##########
sched/misc/assert.c:
##########
@@ -674,6 +674,14 @@ void _assert(FAR const char *filename, int linenum,
#else
for (; ; )
{
+#ifdef CONFIG_ARCH_LEDS
+ /* FLASH LEDs a 2Hz */
+ // board_autoled_on(LED_PANIC);
+ printf("ON\n");
+ up_mdelay(250);
+ printf("OFF\n");
Review Comment:
please polish your code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on a diff in pull request #10553: fix led panic feature
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on code in PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#discussion_r1325449019
##########
arch/arm/src/a1x/a1x_lowputc.c:
##########
@@ -27,13 +27,15 @@
#include <stdint.h>
#include <arch/irq.h>
-#include <arch/board/board.h>
#include "arm_internal.h"
#include "a1x_config.h"
-#include "hardware/a1x_uart.h"
#include "a1x_pio.h"
+#include "hardware/a1x_uart.h"
+
+#include <arch/board/board.h>
Review Comment:
ah alright, i'll revert them then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on a diff in pull request #10553: fix led panic feature
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on code in PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#discussion_r1322952027
##########
arch/arm/src/a1x/hardware/a10_piocfg.h:
##########
@@ -153,12 +153,12 @@
#define PIO_CSI1_D23 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN23)
#define PIO_CSI1_FIELD (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN25)
#define PIO_CSI1_HSYNC (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN2)
-#define PIO_CSI1_HSYNC (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN26)
+// #define PIO_CSI1_HSYNC (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN26)
Review Comment:
Need to come back to this. The `-Werror` flag causes the pipeline to fail as there are redefinition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gregory-nutt commented on pull request #10553: fix led panic feature
Posted by "gregory-nutt (via GitHub)" <gi...@apache.org>.
gregory-nutt commented on PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#issuecomment-1713870567
The header file issue is discussed here: https://cwiki.apache.org/confluence/display/NUTTX/Including+Files+in+board.h including suggestions for avoiding the issue.
It was intended to work that way in order manage the scope of header files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on a diff in pull request #10553: fix led panic feature
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on code in PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#discussion_r1325408922
##########
arch/arm/src/a1x/a1x_lowputc.c:
##########
@@ -27,13 +27,15 @@
#include <stdint.h>
#include <arch/irq.h>
-#include <arch/board/board.h>
#include "arm_internal.h"
#include "a1x_config.h"
-#include "hardware/a1x_uart.h"
#include "a1x_pio.h"
+#include "hardware/a1x_uart.h"
+
+#include <arch/board/board.h>
Review Comment:
it looked more consistent, where u have nuttx specific imports first, then hardware includes then board.h. But i guess i could just revert it as it is unnecessary,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on a diff in pull request #10553: fix led panic feature
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on code in PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#discussion_r1325433206
##########
arch/arm/src/a1x/hardware/a10_piocfg.h:
##########
@@ -414,10 +414,10 @@
#define PIO_SDC0_D2 (PIO_PERIPH2 | PIO_PORT_PIOF | PIO_PIN5)
#define PIO_SDC0_D3 (PIO_PERIPH2 | PIO_PORT_PIOF | PIO_PIN4)
-#define PIO_SDC1_CLK (PIO_PERIPH4 | PIO_PORT_PIOG | PIO_PIN1)
-// #define PIO_SDC1_CLK (PIO_PERIPH5 | PIO_PORT_PIOH | PIO_PIN23)
-#define PIO_SDC1_CMD (PIO_PERIPH4 | PIO_PORT_PIOG | PIO_PIN0)
-// #define PIO_SDC1_CMD (PIO_PERIPH5 | PIO_PORT_PIOH | PIO_PIN22)
+#define PIO_SDC1_CLK_1 (PIO_PERIPH4 | PIO_PORT_PIOG | PIO_PIN1)
+#define PIO_SDC1_CLK_2 (PIO_PERIPH5 | PIO_PORT_PIOH | PIO_PIN23)
+#define PIO_SDC1_CMD_1 (PIO_PERIPH4 | PIO_PORT_PIOG | PIO_PIN0)
+#define PIO_SDC1_CMD_2 (PIO_PERIPH5 | PIO_PORT_PIOH | PIO_PIN22)
Review Comment:
i will squash all my commits soon :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #10553: fix led panic feature
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10553:
URL: https://github.com/apache/nuttx/pull/10553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10553: fix led panic feature
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#discussion_r1325420577
##########
arch/arm/src/a1x/a1x_lowputc.c:
##########
@@ -27,13 +27,15 @@
#include <stdint.h>
#include <arch/irq.h>
-#include <arch/board/board.h>
#include "arm_internal.h"
#include "a1x_config.h"
-#include "hardware/a1x_uart.h"
#include "a1x_pio.h"
+#include "hardware/a1x_uart.h"
+
+#include <arch/board/board.h>
Review Comment:
normally, <> puts before "".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on a diff in pull request #10553: fix led panic feature
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on code in PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#discussion_r1320724769
##########
sched/misc/assert.c:
##########
@@ -674,6 +674,14 @@ void _assert(FAR const char *filename, int linenum,
#else
for (; ; )
{
+#ifdef CONFIG_ARCH_LEDS
+ /* FLASH LEDs a 2Hz */
+ // board_autoled_on(LED_PANIC);
+ printf("ON\n");
+ up_mdelay(250);
+ printf("OFF\n");
Review Comment:
it does, i tested on the on the f411e-disco, this is just for debug until i figure out how to includ board specifics so that i can call `LED_PANIC`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on pull request #10553: fix led panic feature
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#issuecomment-1712757864
> Please also include a Summary and commit message explaining what you want to fix exactly.
>
> As I told you, Panic LED is working, but your board needs to include the files needed to support it. :-)
This PR is clearly a WIP. I am not entirely sure what is the best course of action. Checkout the issue #10479, I think we found a problem with the LED_PANIC and LED_ASSERTION never being called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] TimJTi commented on pull request #10553: fix led panic feature
Posted by "TimJTi (via GitHub)" <gi...@apache.org>.
TimJTi commented on PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#issuecomment-1718225484
> Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/a1x/hardware/a10_piocfg.h:120:1: error: Blank line contains whitespace
./tools/checkpatch.sh is your friend...I found out the hard way <face palm>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on pull request #10553: fix led panic feature
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#issuecomment-1713794492
> please fix the ci compile error.
@xiaoxiang781216 before i attack the fix for CI. I would like to confirm the strategy on `<arch/board/board.h>`. Because I noticed that many users have included their boards iomux/hardware/mcu specific headers in the boards `boards.h` which causes the build to fail for example:
```
Building NuttX...
In file included from ./misc/assert.c:39:
/github/workspace/sources/nuttx/include/arch/board/board.h:34:10: fatal error: stm32_rcc.h: No such file or directory
34 | #include "stm32_rcc.h"
| ^~~~~~~~~~~~~
compilation terminated.
```
In terms of strategy should users define other mcu specific headers in this file or should they be included in sources that require it (the latter seems more logical). To make it clearer we can look at the following 2 files:
### stm32f411-minimum
file: `boards/arm/stm32/stm32f411-minimum/include/board.h`
Include:
```
/****************************************************************************
* Included Files
****************************************************************************/
#include <nuttx/config.h>
#ifndef __ASSEMBLY__
# include <stdint.h>
#endif
#include <stm32.h> // CAUSES BUILD TO FAIL
```
In this case the build fails as it is unable to resolve `stm32.h`
### stm32f103-minimum
file: `boards/arm/stm32/stm32f103-minimum/include/board.h`
Include:
```
/****************************************************************************
* Included Files
****************************************************************************/
#include <nuttx/config.h>
#ifndef __ASSEMBLY__
# include <stdint.h>
#endif
```
Here everything works fine and the user include `stm32.h` in the sources that need it.
I would like to know your opinion. Based on that I will either go ahead and clean up the `board.h` headers for all failing boards and include them to the board sources. Otherwise i am not sure what we should do :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #10553: fix led panic feature
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#discussion_r1320579646
##########
sched/misc/assert.c:
##########
@@ -674,6 +674,14 @@ void _assert(FAR const char *filename, int linenum,
#else
for (; ; )
{
+#ifdef CONFIG_ARCH_LEDS
+ /* FLASH LEDs a 2Hz */
+ // board_autoled_on(LED_PANIC);
+ printf("ON\n");
+ up_mdelay(250);
+ printf("OFF\n");
Review Comment:
Using printf() here in the kernel doesn't appear correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #10553: fix led panic feature
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#issuecomment-1713733515
please fix the ci compile error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #10553: fix led panic feature
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#issuecomment-1712525445
Very nice @trns1997 ! Please replace the C++ comment ( // ) with C comment ( /* ..... */ )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10553: fix led panic feature
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#discussion_r1325209786
##########
arch/arm/src/a1x/a1x_lowputc.c:
##########
@@ -27,13 +27,15 @@
#include <stdint.h>
#include <arch/irq.h>
-#include <arch/board/board.h>
#include "arm_internal.h"
#include "a1x_config.h"
-#include "hardware/a1x_uart.h"
#include "a1x_pio.h"
+#include "hardware/a1x_uart.h"
+
+#include <arch/board/board.h>
Review Comment:
why not keep it in the original place?
##########
arch/arm/src/a1x/a1x_timerisr.c:
##########
@@ -31,9 +31,9 @@
#include <nuttx/arch.h>
#include <arch/irq.h>
-#include <arch/board/board.h>
#include "arm_internal.h"
+
Review Comment:
revert
##########
arch/arm/src/a1x/a1x_serial.c:
##########
@@ -42,14 +42,16 @@
#include <nuttx/fs/ioctl.h>
#include <nuttx/serial/serial.h>
-#include <arch/board/board.h>
-
#include "arm_internal.h"
#include "chip.h"
-#include "hardware/a1x_uart.h"
+#include "a1x_config.h"
#include "a1x_pio.h"
#include "a1x_serial.h"
+#include "hardware/a1x_uart.h"
+
+#include <arch/board/board.h>
Review Comment:
ditto
##########
arch/arm/src/lpc31xx/lpc31_i2c.c:
##########
@@ -38,15 +38,16 @@
#include <nuttx/mutex.h>
#include <nuttx/semaphore.h>
#include <nuttx/i2c/i2c_master.h>
-
#include <nuttx/irq.h>
-#include <arch/board/board.h>
#include "chip.h"
#include "arm_internal.h"
#include "lpc31_i2c.h"
#include "lpc31_evntrtr.h"
#include "lpc31_syscreg.h"
+#include "lpc31_cgudrvr.h"
+
+#include <arch/board/board.h>
Review Comment:
why change tje order
##########
boards/arm/a1x/pcduino-a10/src/a1x_leds.c:
##########
@@ -29,12 +29,13 @@
#include <debug.h>
#include <nuttx/board.h>
-#include <arch/board/board.h>
#include "chip.h"
#include "arm_internal.h"
#include "pcduino_a10.h"
+#include <arch/board/board.h>
Review Comment:
ditto
##########
boards/arm/a1x/pcduino-a10/src/a1x_buttons.c:
##########
@@ -32,10 +32,11 @@
#include <nuttx/irq.h>
#include <nuttx/irq.h>
-#include <arch/board/board.h>
#include "pcduino_a10.h"
+#include <arch/board/board.h>
Review Comment:
why change?
##########
boards/arm/eoss3/quickfeather/src/eoss3_autoleds.c:
##########
@@ -28,10 +28,12 @@
#include <debug.h>
#include <nuttx/board.h>
-#include <arch/board/board.h>
#include "chip.h"
#include "arm_internal.h"
+#include "eoss3_gpio.h"
+
+#include <arch/board/board.h>
Review Comment:
why change the order
##########
arch/arm/src/lpc31xx/lpc31_timerisr.c:
##########
@@ -29,12 +29,14 @@
#include <debug.h>
#include <nuttx/arch.h>
-#include <arch/board/board.h>
#include "clock/clock.h"
#include "arm_internal.h"
#include "lpc31_timer.h"
#include "lpc31.h"
+#include "lpc31_cgudrvr.h"
+
+#include <arch/board/board.h>
Review Comment:
ditto
##########
sched/misc/assert.c:
##########
@@ -48,6 +46,8 @@
#include "sched/sched.h"
#include "group/group.h"
+#include <arch/board/board.h>
Review Comment:
ditto
##########
arch/arm/src/a1x/hardware/a10_piocfg.h:
##########
@@ -414,10 +414,10 @@
#define PIO_SDC0_D2 (PIO_PERIPH2 | PIO_PORT_PIOF | PIO_PIN5)
#define PIO_SDC0_D3 (PIO_PERIPH2 | PIO_PORT_PIOF | PIO_PIN4)
-#define PIO_SDC1_CLK (PIO_PERIPH4 | PIO_PORT_PIOG | PIO_PIN1)
-// #define PIO_SDC1_CLK (PIO_PERIPH5 | PIO_PORT_PIOH | PIO_PIN23)
-#define PIO_SDC1_CMD (PIO_PERIPH4 | PIO_PORT_PIOG | PIO_PIN0)
-// #define PIO_SDC1_CMD (PIO_PERIPH5 | PIO_PORT_PIOH | PIO_PIN22)
+#define PIO_SDC1_CLK_1 (PIO_PERIPH4 | PIO_PORT_PIOG | PIO_PIN1)
+#define PIO_SDC1_CLK_2 (PIO_PERIPH5 | PIO_PORT_PIOH | PIO_PIN23)
+#define PIO_SDC1_CMD_1 (PIO_PERIPH4 | PIO_PORT_PIOG | PIO_PIN0)
+#define PIO_SDC1_CMD_2 (PIO_PERIPH5 | PIO_PORT_PIOH | PIO_PIN22)
Review Comment:
let's move the change to the original patch
##########
boards/arm/stm32/emw3162/src/stm32_wlan.c:
##########
@@ -29,13 +29,14 @@
#include <nuttx/wireless/ieee80211/bcmf_sdio.h>
#include <nuttx/wireless/ieee80211/bcmf_board.h>
-#include <arch/board/board.h>
-
+#include "stm32.h"
#include "stm32_gpio.h"
#include "stm32_sdio.h"
#include "emw3162.h"
+#include <arch/board/board.h>
Review Comment:
ditto
##########
arch/arm/src/a1x/hardware/a10_piocfg.h:
##########
@@ -97,68 +97,68 @@
/* Camera Sensor Interface (CSI) */
-#define PIO_CSI0_CK (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN1)
-#define PIO_CSI0_D0 (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN4)
-#define PIO_CSI0_D1 (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN5)
-#define PIO_CSI0_D2 (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN6)
-#define PIO_CSI0_D3 (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN7)
-#define PIO_CSI0_D4 (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN8)
-#define PIO_CSI0_D5 (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN9)
-#define PIO_CSI0_D6 (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN10)
-#define PIO_CSI0_D7 (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN11)
-#define PIO_CSI0_D8 (PIO_PERIPH5 | PIO_PORT_PIOG | PIO_PIN4)
-#define PIO_CSI0_D9 (PIO_PERIPH5 | PIO_PORT_PIOG | PIO_PIN5)
-#define PIO_CSI0_D10 (PIO_PERIPH5 | PIO_PORT_PIOG | PIO_PIN6)
-#define PIO_CSI0_D11 (PIO_PERIPH5 | PIO_PORT_PIOG | PIO_PIN7)
-#define PIO_CSI0_D12 (PIO_PERIPH5 | PIO_PORT_PIOG | PIO_PIN8)
-#define PIO_CSI0_D13 (PIO_PERIPH5 | PIO_PORT_PIOG | PIO_PIN9)
-#define PIO_CSI0_D14 (PIO_PERIPH5 | PIO_PORT_PIOG | PIO_PIN10)
-#define PIO_CSI0_D15 (PIO_PERIPH5 | PIO_PORT_PIOG | PIO_PIN11)
-#define PIO_CSI0_HSYNC (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN2)
-#define PIO_CSI0_PCK (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN0)
-#define PIO_CSI0_VSYNC (PIO_PERIPH3 | PIO_PORT_PIOE | PIO_PIN3)
-
-#define PIO_CSI1_CK (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN1)
-#define PIO_CSI1_D0_1 (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN4)
-#define PIO_CSI1_D0_2 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN0)
-#define PIO_CSI1_D1_1 (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN5)
-#define PIO_CSI1_D1_2 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN1)
-#define PIO_CSI1_D2_1 (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN6)
-#define PIO_CSI1_D2_2 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN2)
-#define PIO_CSI1_D3_1 (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN7)
-#define PIO_CSI1_D3_2 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN3)
-#define PIO_CSI1_D4_1 (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN8)
-#define PIO_CSI1_D4_2 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN4)
-#define PIO_CSI1_D5_1 (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN9)
-#define PIO_CSI1_D5_2 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN5)
-#define PIO_CSI1_D6_1 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN6)
-#define PIO_CSI1_D6_2 (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN10)
-#define PIO_CSI1_D7_1 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN7)
-#define PIO_CSI1_D7_2 (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN11)
-#define PIO_CSI1_D8 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN8)
-#define PIO_CSI1_D9 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN9)
-#define PIO_CSI1_D10 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN10)
-#define PIO_CSI1_D11 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN11)
-#define PIO_CSI1_D12 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN12)
-#define PIO_CSI1_D13 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN13)
-#define PIO_CSI1_D14 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN14)
-#define PIO_CSI1_D15 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN15)
-#define PIO_CSI1_D16 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN16)
-#define PIO_CSI1_D17 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN17)
-#define PIO_CSI1_D18 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN18)
-#define PIO_CSI1_D19 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN19)
-#define PIO_CSI1_D20 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN20)
-#define PIO_CSI1_D21 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN21)
-#define PIO_CSI1_D22 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN22)
-#define PIO_CSI1_D23 (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN23)
-#define PIO_CSI1_FIELD (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN25)
-#define PIO_CSI1_HSYNC (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN2)
-// #define PIO_CSI1_HSYNC (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN26)
-#define PIO_CSI1_MCLK (PIO_PERIPH3 | PIO_PORT_PIOD | PIO_PIN20)
-#define PIO_CSI1_PCK (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN0)
-#define PIO_CSI1_PCLK (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN24)
-#define PIO_CSI1_VSYNC (PIO_PERIPH3 | PIO_PORT_PIOG | PIO_PIN3)
-// #define PIO_CSI1_VSYNC (PIO_PERIPH7 | PIO_PORT_PIOH | PIO_PIN27)
Review Comment:
fix in the original patch
##########
arch/arm/src/lpc31xx/lpc31_spi.c:
##########
@@ -35,10 +35,11 @@
#include <nuttx/mutex.h>
#include <nuttx/spi/spi.h>
-#include <arch/board/board.h>
-
#include "lpc31_spi.h"
#include "lpc31_ioconfig.h"
+#include "lpc31_cgudrvr.h"
+
+#include <arch/board/board.h>
Review Comment:
ditto
##########
boards/arm/stm32/mikroe-stm32f4/src/stm32_clockconfig.c:
##########
@@ -26,11 +26,13 @@
#include <debug.h>
-#include <arch/board/board.h>
+#include "stm32.h"
#include "arm_internal.h"
#include "mikroe-stm32f4.h"
+#include <arch/board/board.h>
Review Comment:
ditto
##########
boards/arm/lpc31xx/ea3152/src/lpc31_spi.c:
##########
@@ -29,13 +29,14 @@
#include <debug.h>
#include <nuttx/spi/spi.h>
-#include <arch/board/board.h>
#include "arm_internal.h"
#include "chip.h"
#include "lpc31.h"
#include "ea3152.h"
+#include <arch/board/board.h>
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on pull request #10553: fix led panic feature
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#issuecomment-1713883947
> The header file issue is discussed here: https://cwiki.apache.org/confluence/display/NUTTX/Including+Files+in+board.h including suggestions for avoiding the issue.
>
> It was intended to work that way in order manage the scope of header files.
The doc states the following:
```
So How Do I Avoid This?
The only way to avoid this header file inclusion trap is:
Never include architecture-specific header files in the board.h header file. Instead,
Include the header files needed by the the board.h header file in the C file that includes board.h
Make sure that board.h is the last header file included.
```
I guess i will go ahead and clean up the `board.h` files and remove the architecture-specific headers. That way everything is coherent and the LED_PANIC feature is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] trns1997 commented on a diff in pull request #10553: fix led panic feature
Posted by "trns1997 (via GitHub)" <gi...@apache.org>.
trns1997 commented on code in PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#discussion_r1320724769
##########
sched/misc/assert.c:
##########
@@ -674,6 +674,14 @@ void _assert(FAR const char *filename, int linenum,
#else
for (; ; )
{
+#ifdef CONFIG_ARCH_LEDS
+ /* FLASH LEDs a 2Hz */
+ // board_autoled_on(LED_PANIC);
+ printf("ON\n");
+ up_mdelay(250);
+ printf("OFF\n");
Review Comment:
it does, i tested on the on the f411e-disco
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Siviuze commented on pull request #10553: fix led panic feature
Posted by "Siviuze (via GitHub)" <gi...@apache.org>.
Siviuze commented on PR #10553:
URL: https://github.com/apache/nuttx/pull/10553#issuecomment-1713450091
> Please also include a Summary and commit message explaining what you want to fix exactly.
>
> As I told you, Panic LED is working, but your board needs to include the files needed to support it. :-)
It seems that the code was lost (following the pointed PR in https://github.com/apache/nuttx/issues/10479). I cannot find the call to LED_PANIC in sched/misc/assert.c:676 where it seems to belong (cf. nuttx-11) nor anywhere in the code base (grep -rn "board_autoled_on(LED_PANIC)" return nothing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org