You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by tabish121 <gi...@git.apache.org> on 2018/08/30 19:01:18 UTC
[GitHub] activemq-artemis pull request #2284: ARTEMIS-2067 Clean up some code in the ...
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2284
ARTEMIS-2067 Clean up some code in the AMQP protocol handling paths
Cleans up some of the code on the proton event handler, most noteable:
1. Fix IOCallback creation on each outbound send, use single instance
as the handler only ever does a flush and has no attached state.
2. Fix redundent locking and unlocking of connection lock on the event
path that already ensures that lock is held.
3. Set presettle state on the server sender at attach as it cannot
change afterwards so checking on every message is not needed.
4. Improve buffer type checking on receive to reduce amount of work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis proton-cleanups
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2284.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2284
----
commit 4349bd16d406dd883b077ba3339bd89a70d4acd0
Author: Timothy Bish <ta...@...>
Date: 2018-08-30T18:32:01Z
ARTEMIS-2067 Clean up some code in the AMQP protocol handling paths
Cleans up some of the code on the proton event handler, most noteable:
1. Fix IOCallback creation on each outbound send, use single instance
as the handler only ever does a flush and has no attached state.
2. Fix redundent locking and unlocking of connection lock on the event
path that already ensures that lock is held.
3. Set presettle state on the server sender at attach as it cannot
change afterwards so checking on every message is not needed.
4. Improve buffer type checking on receive to reduce amount of work
----
---
[GitHub] activemq-artemis issue #2284: ARTEMIS-2067 Clean up some code in the AMQP pr...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2284
@tabish121 you ok to leave this one out of 2.6.3? we can bring it into 2.6.4
---
[GitHub] activemq-artemis issue #2284: ARTEMIS-2067 Clean up some code in the AMQP pr...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2284
@tabish121 sure.. but I usually like to bring any bug fix into 2.6.x...
I will leave this one out then.
---
[GitHub] activemq-artemis issue #2284: ARTEMIS-2067 Clean up some code in the AMQP pr...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2284
Sync'd with master, test failure seems unrelated to AMQP
---
[GitHub] activemq-artemis pull request #2284: ARTEMIS-2067 Clean up some code in the ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2284
---
[GitHub] activemq-artemis issue #2284: ARTEMIS-2067 Clean up some code in the AMQP pr...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2284
I targeted 2.7.0 in the JIRA as I don't think it is a critical fix can add it on next cycle if you want.
---