You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/14 19:09:25 UTC
[GitHub] [airflow] DMilmont opened a new pull request, #26401: Update manage-dags-files.rst
DMilmont opened a new pull request, #26401:
URL: https://github.com/apache/airflow/pull/26401
This removes the wording that baking DAGs into a docker image is the recommended way. Additionally it calls out the downside of doing so.
closes: [#ISSUE](https://github.com/apache/airflow/issues/26262)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] DMilmont commented on a diff in pull request #26401: Update documentation - baking DAGs into docker image
Posted by GitBox <gi...@apache.org>.
DMilmont commented on code in PR #26401:
URL: https://github.com/apache/airflow/pull/26401#discussion_r972372964
##########
docs/helm-chart/manage-dags-files.rst:
##########
@@ -24,7 +24,9 @@ When you create new or modify existing DAG files, it is necessary to deploy them
Bake DAGs in Docker image
-------------------------
-The recommended way to update your DAGs with this chart is to build a new Docker image with the latest DAG code:
+This option uses the Docker image containing the latest DAG code.
+
+This method requires redeploying the services in the helm chart with the new docker image in order to use the new DAG code. This might be a good option if DAG code is not expected to change frequently.
Review Comment:
I like it! Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #26401: Update documentation - baking DAGs into docker image
Posted by GitBox <gi...@apache.org>.
jedcunningham merged PR #26401:
URL: https://github.com/apache/airflow/pull/26401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #26401: Update documentation - baking DAGs into docker image
Posted by GitBox <gi...@apache.org>.
dstandish commented on code in PR #26401:
URL: https://github.com/apache/airflow/pull/26401#discussion_r972264023
##########
docs/helm-chart/manage-dags-files.rst:
##########
@@ -24,7 +24,9 @@ When you create new or modify existing DAG files, it is necessary to deploy them
Bake DAGs in Docker image
-------------------------
-The recommended way to update your DAGs with this chart is to build a new Docker image with the latest DAG code:
+This option uses the Docker image containing the latest DAG code.
+
+This method requires redeploying the services in the helm chart with the new docker image in order to use the new DAG code. This might be a good option if DAG code is not expected to change frequently.
Review Comment:
```suggestion
With this approach, you include your dag files and related code in the airflow image.
This method requires redeploying the services in the helm chart with the new docker image in order to deploy the new DAG code. This can work well particularly if DAG code is not expected to change frequently.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org