You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "apupier (via GitHub)" <gi...@apache.org> on 2023/08/10 12:33:08 UTC
[GitHub] [camel] apupier opened a new pull request, #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
apupier opened a new pull request, #11067:
URL: https://github.com/apache/camel/pull/11067
keeping KameletBinding working to let transition times for users
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11067:
URL: https://github.com/apache/camel/pull/11067#issuecomment-1673320125
Ah okay, didnt spot that.
But maybe we could just deleted all but 1 old test as its the same logic the Pipe uses, so we dont have to maintain old tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] apupier commented on a diff in pull request #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #11067:
URL: https://github.com/apache/camel/pull/11067#discussion_r1290057936
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/GitHubHelper.java:
##########
@@ -63,11 +63,6 @@ private static void doFetchGithubUrls(
// this is a directory, so we need to query github which files are there and filter them
- // URL: https://api.github.com/repos/apache/camel-k/contents/examples/kamelets/kameletbindings
- // URL: https://api.github.com/repos/apache/camel-k/contents/examples/kamelets/kameletbindings?ref=v1.7.0
- // https://github.com/apache/camel-k/tree/main/examples/kamelets/kameletbindings
- // https://github.com/apache/camel-k/tree/v1.7.0/examples/kamelets/kameletbindings
-
Review Comment:
All these URLs does not exists anymore. Examples were moved to camel-k-examples repo. And I have not found a specific folder of examples for Pipe/KameletBinding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] apupier commented on a diff in pull request #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #11067:
URL: https://github.com/apache/camel/pull/11067#discussion_r1290152872
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/GitHubHelper.java:
##########
@@ -63,11 +63,6 @@ private static void doFetchGithubUrls(
// this is a directory, so we need to query github which files are there and filter them
- // URL: https://api.github.com/repos/apache/camel-k/contents/examples/kamelets/kameletbindings
- // URL: https://api.github.com/repos/apache/camel-k/contents/examples/kamelets/kameletbindings?ref=v1.7.0
- // https://github.com/apache/camel-k/tree/main/examples/kamelets/kameletbindings
- // https://github.com/apache/camel-k/tree/v1.7.0/examples/kamelets/kameletbindings
-
Review Comment:
there are examples but they are not only kameletbindings as it was in the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] apupier commented on a diff in pull request #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #11067:
URL: https://github.com/apache/camel/pull/11067#discussion_r1290155061
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/GitHubHelper.java:
##########
@@ -63,11 +63,6 @@ private static void doFetchGithubUrls(
// this is a directory, so we need to query github which files are there and filter them
- // URL: https://api.github.com/repos/apache/camel-k/contents/examples/kamelets/kameletbindings
- // URL: https://api.github.com/repos/apache/camel-k/contents/examples/kamelets/kameletbindings?ref=v1.7.0
- // https://github.com/apache/camel-k/tree/main/examples/kamelets/kameletbindings
- // https://github.com/apache/camel-k/tree/v1.7.0/examples/kamelets/kameletbindings
-
Review Comment:
there are no tags on camel-k-examples repository neither (and in the url provided it was using tags for some)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] claudio4j commented on a diff in pull request #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on code in PR #11067:
URL: https://github.com/apache/camel/pull/11067#discussion_r1290146623
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/GitHubHelper.java:
##########
@@ -63,11 +63,6 @@ private static void doFetchGithubUrls(
// this is a directory, so we need to query github which files are there and filter them
- // URL: https://api.github.com/repos/apache/camel-k/contents/examples/kamelets/kameletbindings
- // URL: https://api.github.com/repos/apache/camel-k/contents/examples/kamelets/kameletbindings?ref=v1.7.0
- // https://github.com/apache/camel-k/tree/main/examples/kamelets/kameletbindings
- // https://github.com/apache/camel-k/tree/v1.7.0/examples/kamelets/kameletbindings
-
Review Comment:
There are some examples in
https://github.com/apache/camel-kamelets-examples/
https://github.com/apache/camel-k-examples/tree/main/generic-examples/kamelets
https://github.com/apache/camel-k-examples/tree/main/kamelets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] apupier commented on a diff in pull request #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #11067:
URL: https://github.com/apache/camel/pull/11067#discussion_r1290057936
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/GitHubHelper.java:
##########
@@ -63,11 +63,6 @@ private static void doFetchGithubUrls(
// this is a directory, so we need to query github which files are there and filter them
- // URL: https://api.github.com/repos/apache/camel-k/contents/examples/kamelets/kameletbindings
- // URL: https://api.github.com/repos/apache/camel-k/contents/examples/kamelets/kameletbindings?ref=v1.7.0
- // https://github.com/apache/camel-k/tree/main/examples/kamelets/kameletbindings
- // https://github.com/apache/camel-k/tree/v1.7.0/examples/kamelets/kameletbindings
-
Review Comment:
All these URLs does not exists anymore. And I have not found a specific folder of examples for Pipe/KameletBinding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] apupier commented on pull request #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #11067:
URL: https://github.com/apache/camel/pull/11067#issuecomment-1674379056
the PR is failign with: https://github.com/apache/camel/actions/runs/5830292917/job/15811436755#step:8:27
```
There are uncommitted changes
HEAD detached at pull/11067/merge
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/schemas/camel-spring.xsd
no changes added to commit (use "git add" and/or "git commit -a")
diff --git a/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/schemas/camel-spring.xsd b/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/schemas/camel-spring.xsd
index bb6822e416d..0b662159251 100644
--- a/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/schemas/camel-spring.xsd
+++ b/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/schemas/camel-spring.xsd
@@ -439,7 +439,7 @@ Enriches a message with data from a secondary resource
<xs:annotation>
<xs:documentation xml:lang="en">
<![CDATA[
-Error handler settings
+Camel error handling.
]]>
</xs:documentation>
</xs:annotation>
```
i do not see the link with my PR. I had this change locally one time when rebuilding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #11067:
URL: https://github.com/apache/camel/pull/11067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] apupier commented on pull request #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #11067:
URL: https://github.com/apache/camel/pull/11067#issuecomment-1673315856
> Can you copy one of the pipe tests and change it to use the old name, so we have 1 test for backwards
I kept the old one: https://github.com/apupier/camel/blob/19732-migrateFromKameletBindingToPipeNaming/dsl/camel-yaml-dsl/camel-yaml-dsl/src/test/groovy/org/apache/camel/dsl/yaml/KameletBindingLoaderTest.groovy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11067:
URL: https://github.com/apache/camel/pull/11067#issuecomment-1673307766
Can you copy one of the pipe tests and change it to use the old name, so we have 1 test for backwards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] apupier commented on pull request #11067: CAMEL-19732 - Support Pipe in CRDs, replacing KameletBinding
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #11067:
URL: https://github.com/apache/camel/pull/11067#issuecomment-1674355395
> we could just deleted all but 1 old test as its the same logic the Pipe uses, so we dont have to maintain old tests.
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org