You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/12 21:25:53 UTC

[GitHub] kristw opened a new pull request #6376: Update SuperChart onRenderXXX listeners

kristw opened a new pull request #6376: Update SuperChart onRenderXXX listeners
URL: https://github.com/apache/incubator-superset/pull/6376
 
 
   - Remove `skipRendering` flag. Check for existence of `chartProps` instead. 
   - Dispatch listener `onRenderXXX` from the correct place. Before, I was dispatching this from `SuperChart` which does not have full transparency to when the rendering actually happens because the rendering happens in a nested component created by `react-loadable`. This PR extends the nested component generated by `react-loadable` to provide listeners after rendering and use that to trigger `onRenderSuccess` and `onRenderFailure` instead.
   - Manually trigger `preloading` right after `SuperChart` knows the `chartType`. The previous code won't load until `chartProps` is available
   
   @mistercrunch @williaster  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org