You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/30 09:11:40 UTC

[GitHub] [flink] PatrickRen commented on pull request #14789: [FLINK-21159][connector/kafka] Send NoMoreSplitsEvent to all readers even if the reader is not assigned with any splits

PatrickRen commented on pull request #14789:
URL: https://github.com/apache/flink/pull/14789#issuecomment-770181843


   I noticed a race condition in my modification: the variable ```noMoreNewPartitionSplits``` may not be set when ```addReader``` is invoked because they are in different threads, which will cause not sending NoMoreSplitsEvent to some readers. I'll make another commit later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org