You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/06/01 19:46:07 UTC
[kudu-CR] [hms] Support repairing entries with invalid IDs
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13492
Change subject: [hms] Support repairing entries with invalid IDs
......................................................................
[hms] Support repairing entries with invalid IDs
This patch updates the hms tool to support fixing HMS
tables with missing or invalid kudu.table_id properties.
To support this, the patch changes the HMS plugin to
allow tables with unmatched IDs to be altered when
`kudu.check_id` is false in the environment context.
Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
8 files changed, 76 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/13492/1
--
To view, visit http://gerrit.cloudera.org:8080/13492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085
Gerrit-Change-Number: 13492
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [hms] Support repairing entries with invalid IDs
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13492 )
Change subject: [hms] Support repairing entries with invalid IDs
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085
Gerrit-Change-Number: 13492
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:52:40 +0000
Gerrit-HasComments: No
[kudu-CR] [hms] Support repairing entries with invalid IDs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13492
to look at the new patch set (#3).
Change subject: [hms] Support repairing entries with invalid IDs
......................................................................
[hms] Support repairing entries with invalid IDs
This patch updates the hms tool to support fixing HMS
tables with missing or invalid kudu.table_id properties.
To support this, the patch changes the HMS plugin to
allow tables with unmatched IDs to be altered when
`kudu.check_id` is false in the environment context.
Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
8 files changed, 84 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/13492/3
--
To view, visit http://gerrit.cloudera.org:8080/13492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085
Gerrit-Change-Number: 13492
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hms] Support repairing entries with invalid IDs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13492
to look at the new patch set (#2).
Change subject: [hms] Support repairing entries with invalid IDs
......................................................................
[hms] Support repairing entries with invalid IDs
This patch updates the hms tool to support fixing HMS
tables with missing or invalid kudu.table_id properties.
To support this, the patch changes the HMS plugin to
allow tables with unmatched IDs to be altered when
`kudu.check_id` is false in the environment context.
Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
8 files changed, 80 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/13492/2
--
To view, visit http://gerrit.cloudera.org:8080/13492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085
Gerrit-Change-Number: 13492
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hms] Support repairing entries with invalid IDs
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13492 )
Change subject: [hms] Support repairing entries with invalid IDs
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
LGTM, just one minor issue. Thanks a lot for patch!
http://gerrit.cloudera.org:8080/#/c/13492/2/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/13492/2/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@320
PS2, Line 320: return Boolean.parseBoolean(properties.get(KUDU_MASTER_EVENT));
Not your fault, but can you add 'containsKey' check before this? Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/13492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085
Gerrit-Change-Number: 13492
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 03 Jun 2019 04:14:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] [hms] Support repairing entries with invalid IDs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13492 )
Change subject: [hms] Support repairing entries with invalid IDs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13492/2/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/13492/2/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@320
PS2, Line 320: return Boolean.parseBoolean(properties.get(KUDU_MASTER_EVENT));
> Not your fault, but can you add 'containsKey' check before this? Thanks!
Done
--
To view, visit http://gerrit.cloudera.org:8080/13492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085
Gerrit-Change-Number: 13492
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 03 Jun 2019 14:38:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [hms] Support repairing entries with invalid IDs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13492 )
Change subject: [hms] Support repairing entries with invalid IDs
......................................................................
[hms] Support repairing entries with invalid IDs
This patch updates the hms tool to support fixing HMS
tables with missing or invalid kudu.table_id properties.
To support this, the patch changes the HMS plugin to
allow tables with unmatched IDs to be altered when
`kudu.check_id` is false in the environment context.
Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085
Reviewed-on: http://gerrit.cloudera.org:8080/13492
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
8 files changed, 84 insertions(+), 18 deletions(-)
Approvals:
Kudu Jenkins: Verified
Hao Hao: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085
Gerrit-Change-Number: 13492
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)