You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/09/13 15:13:31 UTC
[GitHub] [trafficserver] SolidWallOfCode opened a new pull request #7188: Update sni outbound policy to allow directly setting the outbound SNI.
SolidWallOfCode opened a new pull request #7188:
URL: https://github.com/apache/trafficserver/pull/7188
This changes `proxy.config.ssl.client.sni_policy` to enable setting the SNI for outbound connections literally. This is of marginal utility for global configuration but because this value is transaction overridable the change creates a large scope for use by plugins such as [Transaction Box](https://github.com/SolidWallOfCode/txn_box) or conf_remap.
The leading '@' was chosen because it is similar to '@' headers, using the same leading character to indicate something that will be processed internally, and avoiding any conflict with current or future keywords.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7188: Update sni outbound policy to allow directly setting the outbound SNI.
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7188:
URL: https://github.com/apache/trafficserver/pull/7188#issuecomment-691703001
My first thought was to have a separate plugin API to do this, but then it would interact in non-obvious ways with this overridable setting. I think this is much better precisely because it collides with the setting. If the outbound SNI is to be set to some literal value, it implicitly disables any keyword used for this, therefore IMHO it's best to make that _explicit_. It can be set to a keyword, or a literal, but never both because the latter makes no sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode merged pull request #7188: Update sni outbound policy to allow directly setting the outbound SNI.
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode merged pull request #7188:
URL: https://github.com/apache/trafficserver/pull/7188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode edited a comment on pull request #7188: Update sni outbound policy to allow directly setting the outbound SNI.
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode edited a comment on pull request #7188:
URL: https://github.com/apache/trafficserver/pull/7188#issuecomment-691703001
My first thought was to have a separate plugin API to do this, but then it would interact in non-obvious ways with this overridable setting. I think this is much better precisely because it collides with the setting. If the outbound SNI is to be set to some literal value, it implicitly disables any keyword used for this, therefore IMHO it's best to make that _explicit_. It can be set to a keyword, or a literal, but never both because both makes no sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] mlibbey commented on pull request #7188: Update sni outbound policy to allow directly setting the outbound SNI.
Posted by GitBox <gi...@apache.org>.
mlibbey commented on pull request #7188:
URL: https://github.com/apache/trafficserver/pull/7188#issuecomment-691699527
We've had requests for this feature as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org