You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2019/11/03 23:16:26 UTC
[spark] branch branch-2.4 updated: Revert "[SPARK-24152][R][TESTS]
Disable check-cran from run-tests.sh"
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new 4d2ed47 Revert "[SPARK-24152][R][TESTS] Disable check-cran from run-tests.sh"
4d2ed47 is described below
commit 4d2ed478bed8ed354b560fbaa65888ef2c64594a
Author: Liang-Chi Hsieh <vi...@gmail.com>
AuthorDate: Sun Nov 3 15:14:58 2019 -0800
Revert "[SPARK-24152][R][TESTS] Disable check-cran from run-tests.sh"
### What changes were proposed in this pull request?
This reverts commit 91d990162f13acde546d01e1163ed3e898cbf9a7.
### Why are the changes needed?
CRAN check is pretty important for R package, we should enable it.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Unit tests.
Closes #26381 from viirya/revert-SPARK-24152.
Authored-by: Liang-Chi Hsieh <vi...@gmail.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
(cherry picked from commit e7263242bd9b9b2207147af4ab3ae4ec2ff3c718)
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
R/run-tests.sh | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/R/run-tests.sh b/R/run-tests.sh
index 27537bf..86bd8aa 100755
--- a/R/run-tests.sh
+++ b/R/run-tests.sh
@@ -32,10 +32,8 @@ NUM_TEST_WARNING="$(grep -c -e 'Warnings ----------------' $LOGFILE)"
CRAN_CHECK_LOG_FILE=$FWDIR/cran-check.out
rm -f $CRAN_CHECK_LOG_FILE
-# SPARK-24152 We will add this test back as a separate Jenkins job
-# NO_TESTS=1 NO_MANUAL=1 $FWDIR/check-cran.sh 2>&1 | tee -a $CRAN_CHECK_LOG_FILE
-# FAILED=$((PIPESTATUS[0]||$FAILED))
-touch $CRAN_CHECK_LOG_FILE
+NO_TESTS=1 NO_MANUAL=1 $FWDIR/check-cran.sh 2>&1 | tee -a $CRAN_CHECK_LOG_FILE
+FAILED=$((PIPESTATUS[0]||$FAILED))
NUM_CRAN_WARNING="$(grep -c WARNING$ $CRAN_CHECK_LOG_FILE)"
NUM_CRAN_ERROR="$(grep -c ERROR$ $CRAN_CHECK_LOG_FILE)"
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org