[GitHub] [samza] Sanil15 commented on a change in pull request #1414: SAMZA-2579: Force restart feature for Container Placements

[GitBox <gi...@apache.org>]

Sanil15 commented on a change in pull request #1414:
URL: https://github.com/apache/samza/pull/1414#discussion_r474334769



##########
File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerManager.java
##########
@@ -54,6 +54,8 @@
 
   private static final Logger LOG = LoggerFactory.getLogger(ContainerManager.class);
   private static final String ANY_HOST = ResourceRequestState.ANY_HOST;
+  private static final String LAST_SEEN = "LAST_SEEN";
+  private static final String FORCE_RESTART_LAST_SEEN = "FORCE_RESTART_LAST_SEEN";

Review comment:
       discussed offline, its the destinationHost param which is.
   
   **All its really doing is issuing a stop and relying on the AM to bring it back up?**
   Yup that is what is it doing
   
   **In a corner case, AM will not be able to bring it back up on the same host, rather on a different available host?**
   Yes and that is documented
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org