You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/11 04:17:45 UTC

[GitHub] [pulsar] liudezhi2098 opened a new pull request, #15110: [broker] fix parameter saslJaasBrokerSectionName in broker.conf

liudezhi2098 opened a new pull request, #15110:
URL: https://github.com/apache/pulsar/pull/15110

   ### Motivation
   when the parameter saslJaasBrokerSectionName is set, it does not take effect  ， becase  `ServiceConfiguration` is saslJaasServerSectionName  not match.
   ```
    @FieldContext(
           category = CATEGORY_SASL_AUTH,
           doc = "Service Principal, for login context name. Default value is \"PulsarBroker\"."
       )
       private String saslJaasServerSectionName = SaslConstants.JAAS_DEFAULT_BROKER_SECTION_NAME;
   ```
   
   ### Modifications
   alert conf 
   `# Service Principal, for login context name.`
   `# Default value `SaslConstants.JAAS_DEFAULT_BROKER_SECTION_NAME`, which is "Broker".`
   `saslJaasServerSectionName=`
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (no)
     - The schema: (no )
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: ( no)
     - Anything that affects deployment: (yes)
   
   ### Documentation
   
   Need to update docs? 
   
   - [x] `no-need-doc` 
     
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liudezhi2098 commented on pull request #15110: [broker] fix parameter saslJaasBrokerSectionName in broker.conf

Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on PR #15110:
URL: https://github.com/apache/pulsar/pull/15110#issuecomment-1094595753

   > @liudezhi2098 We'd better also update the docs.
   
   yes, should update the docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liudezhi2098 commented on pull request #15110: [broker] fix parameter saslJaasBrokerSectionName in broker.conf

Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on PR #15110:
URL: https://github.com/apache/pulsar/pull/15110#issuecomment-1096185546

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liudezhi2098 commented on pull request #15110: [broker] fix parameter saslJaasBrokerSectionName in broker.conf

Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on PR #15110:
URL: https://github.com/apache/pulsar/pull/15110#issuecomment-1094584161

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaozhangmin commented on pull request #15110: [broker] fix parameter saslJaasBrokerSectionName in broker.conf

Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #15110:
URL: https://github.com/apache/pulsar/pull/15110#issuecomment-1094589734

   @liudezhi2098 We'd better also update the docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #15110: [broker] fix parameter saslJaasBrokerSectionName in broker.conf

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #15110:
URL: https://github.com/apache/pulsar/pull/15110


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org