You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sneha Kanekar <sk...@us.ibm.com> on 2017/12/07 09:35:08 UTC
Review Request 64407: AMBARI-22592: Set ambari.repo. in
ambari-server setup script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-22592
https://issues.apache.org/jira/browse/AMBARI-22592
Repository: ambari
Description
-------
The ambari-server setup script is updated to allow the user to store/update Ambari repo base URL in ambari.properties file for each OS type through command line. The command to set Ambari repo URL : ambari-server setup --ambari-repo <Ambari_Repo_URL>
Diffs
-----
ambari-server/src/main/python/ambari-server.py 188910e
ambari-server/src/main/python/ambari_server/serverConfiguration.py f744fa0
ambari-server/src/main/python/ambari_server/serverSetup.py af45584
ambari-server/src/test/python/TestAmbariServer.py ad4e371
Diff: https://reviews.apache.org/r/64407/diff/1/
Testing
-------
Tests were successful in ambari-server.
Thanks,
Sneha Kanekar
Re: Review Request 64407: AMBARI-22592: Set ambari.repo. in
ambari-server setup script
Posted by Yussuf Shaikh <yu...@us.ibm.com>.
> On Dec. 7, 2017, 2:53 p.m., Nate Cole wrote:
> > ambari-server/src/main/python/ambari_server/serverSetup.py
> > Lines 1140-1141 (patched)
> > <https://reviews.apache.org/r/64407/diff/1/?file=1910337#file1910337line1140>
> >
> > Can this somehow be validated to the known, good os family values? If not, this is still ok.
we take all input as os_type for now, can validate in future
- Yussuf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/#review193119
-----------------------------------------------------------
On Dec. 7, 2017, 9:35 a.m., Sneha Kanekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64407/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 9:35 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22592
> https://issues.apache.org/jira/browse/AMBARI-22592
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ambari-server setup script is updated to allow the user to store/update Ambari repo base URL in ambari.properties file for each OS type through command line. The command to set Ambari repo URL : ambari-server setup --ambari-repo <Ambari_Repo_URL>
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 188910e
> ambari-server/src/main/python/ambari_server/serverConfiguration.py f744fa0
> ambari-server/src/main/python/ambari_server/serverSetup.py af45584
> ambari-server/src/test/python/TestAmbariServer.py ad4e371
>
>
> Diff: https://reviews.apache.org/r/64407/diff/1/
>
>
> Testing
> -------
>
> Tests were successful in ambari-server.
>
>
> Thanks,
>
> Sneha Kanekar
>
>
Re: Review Request 64407: AMBARI-22592: Set ambari.repo. in
ambari-server setup script
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/#review193119
-----------------------------------------------------------
ambari-server/src/main/python/ambari_server/serverSetup.py
Lines 1140-1141 (patched)
<https://reviews.apache.org/r/64407/#comment271623>
Can this somehow be validated to the known, good os family values? If not, this is still ok.
ambari-server/src/main/python/ambari_server/serverSetup.py
Lines 1199 (patched)
<https://reviews.apache.org/r/64407/#comment271622>
nit: formatting (odd space)
- Nate Cole
On Dec. 7, 2017, 4:35 a.m., Sneha Kanekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64407/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 4:35 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22592
> https://issues.apache.org/jira/browse/AMBARI-22592
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ambari-server setup script is updated to allow the user to store/update Ambari repo base URL in ambari.properties file for each OS type through command line. The command to set Ambari repo URL : ambari-server setup --ambari-repo <Ambari_Repo_URL>
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 188910e
> ambari-server/src/main/python/ambari_server/serverConfiguration.py f744fa0
> ambari-server/src/main/python/ambari_server/serverSetup.py af45584
> ambari-server/src/test/python/TestAmbariServer.py ad4e371
>
>
> Diff: https://reviews.apache.org/r/64407/diff/1/
>
>
> Testing
> -------
>
> Tests were successful in ambari-server.
>
>
> Thanks,
>
> Sneha Kanekar
>
>
Re: Review Request 64407: AMBARI-22592: Set ambari.repo. in
ambari-server setup script
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/#review193547
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Dec. 8, 2017, 5:57 a.m., Sneha Kanekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64407/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 5:57 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22592
> https://issues.apache.org/jira/browse/AMBARI-22592
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ambari-server setup script is updated to allow the user to store/update Ambari repo base URL in ambari.properties file for each OS type through command line. The command to set Ambari repo URL : ambari-server setup --ambari-repo <Ambari_Repo_URL>
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 188910e
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 27b4472
> ambari-server/src/main/python/ambari_server/serverSetup.py 3b41fff
> ambari-server/src/test/python/TestAmbariServer.py ad4e371
>
>
> Diff: https://reviews.apache.org/r/64407/diff/2/
>
>
> Testing
> -------
>
> Tests were successful in ambari-server.
>
>
> Thanks,
>
> Sneha Kanekar
>
>
Re: Review Request 64407: AMBARI-22592: Set ambari.repo. in
ambari-server setup script
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/#review193562
-----------------------------------------------------------
ambari-server/src/test/python/TestAmbariServer.py
Lines 3703 (patched)
<https://reviews.apache.org/r/64407/#comment272123>
`with self.assertRaises(FatalException):`
ambari-server/src/test/python/TestAmbariServer.py
Lines 3884 (patched)
<https://reviews.apache.org/r/64407/#comment272125>
`with self.assertRaises(FatalException):`
- Matt
On Dec. 8, 2017, 2:57 a.m., Sneha Kanekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64407/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 2:57 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22592
> https://issues.apache.org/jira/browse/AMBARI-22592
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ambari-server setup script is updated to allow the user to store/update Ambari repo base URL in ambari.properties file for each OS type through command line. The command to set Ambari repo URL : ambari-server setup --ambari-repo <Ambari_Repo_URL>
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 188910e
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 27b4472
> ambari-server/src/main/python/ambari_server/serverSetup.py 3b41fff
> ambari-server/src/test/python/TestAmbariServer.py ad4e371
>
>
> Diff: https://reviews.apache.org/r/64407/diff/2/
>
>
> Testing
> -------
>
> Tests were successful in ambari-server.
>
>
> Thanks,
>
> Sneha Kanekar
>
>
Re: Review Request 64407: AMBARI-22592: Set ambari.repo. in
ambari-server setup script
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/#review193549
-----------------------------------------------------------
This has been pushed. Please close this review and associated JIRA.
- Nate Cole
On Dec. 8, 2017, 5:57 a.m., Sneha Kanekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64407/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 5:57 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-22592
> https://issues.apache.org/jira/browse/AMBARI-22592
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The ambari-server setup script is updated to allow the user to store/update Ambari repo base URL in ambari.properties file for each OS type through command line. The command to set Ambari repo URL : ambari-server setup --ambari-repo <Ambari_Repo_URL>
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 188910e
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 27b4472
> ambari-server/src/main/python/ambari_server/serverSetup.py 3b41fff
> ambari-server/src/test/python/TestAmbariServer.py ad4e371
>
>
> Diff: https://reviews.apache.org/r/64407/diff/2/
>
>
> Testing
> -------
>
> Tests were successful in ambari-server.
>
>
> Thanks,
>
> Sneha Kanekar
>
>
Re: Review Request 64407: AMBARI-22592: Set ambari.repo. in
ambari-server setup script
Posted by Sneha Kanekar <sk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/
-----------------------------------------------------------
(Updated Dec. 8, 2017, 10:57 a.m.)
Review request for Ambari and Nate Cole.
Changes
-------
Removed odd spaces and also corrected the patch according to the latest changes in feature branch.
Bugs: AMBARI-22592
https://issues.apache.org/jira/browse/AMBARI-22592
Repository: ambari
Description
-------
The ambari-server setup script is updated to allow the user to store/update Ambari repo base URL in ambari.properties file for each OS type through command line. The command to set Ambari repo URL : ambari-server setup --ambari-repo <Ambari_Repo_URL>
Diffs (updated)
-----
ambari-server/src/main/python/ambari-server.py 188910e
ambari-server/src/main/python/ambari_server/serverConfiguration.py 27b4472
ambari-server/src/main/python/ambari_server/serverSetup.py 3b41fff
ambari-server/src/test/python/TestAmbariServer.py ad4e371
Diff: https://reviews.apache.org/r/64407/diff/2/
Changes: https://reviews.apache.org/r/64407/diff/1-2/
Testing
-------
Tests were successful in ambari-server.
Thanks,
Sneha Kanekar