[GitHub] [incubator-doris] imay commented on a change in pull request #2089: Change refactor and reorganize the file utils

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2089: Change refactor and reorganize the file utils 
URL: https://github.com/apache/incubator-doris/pull/2089#discussion_r339902752
 
 

 ##########
 File path: be/src/env/env_posix.cpp
 ##########
 @@ -590,9 +591,26 @@ class PosixEnv : public Env {
     }
 
     // Create the specified directory. Returns error if directory exists.
-    Status create_dir(const std::string& name) override {
-        if (mkdir(name.c_str(), 0755) != 0) {
-            return io_error(name, errno);
+    Status create_dir(const std::string& dir_path) override {
 
 Review comment:
   This interface is to create a directory, not create a directory recursively.
   And create directory recursively should be implemented in file_utils, because it's the same logic for different types of Env.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org