You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/06 16:29:14 UTC

[GitHub] [spark] pgandhi999 commented on a change in pull request #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So…

pgandhi999 commented on a change in pull request #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So…
URL: https://github.com/apache/spark/pull/24149#discussion_r281258992
 
 

 ##########
 File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDAFSuite.scala
 ##########
 @@ -123,6 +133,26 @@ class HiveUDAFSuite extends QueryTest with TestHiveSingleton with SQLTestUtils {
     }
   }
 
+  test("SPARK-27207: customized Hive UDAF with two aggregation buffers for Sort" +
 
 Review comment:
   So it used to fail earlier without my patch, but your latest patch seems to have fixed it. Will come up with another test case. Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org