You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ivo Danihelka (JIRA)" <ji...@apache.org> on 2009/02/09 15:22:59 UTC
[jira] Created: (WICKET-2091) Error feedback is hidden by lower
level messages
Error feedback is hidden by lower level messages
------------------------------------------------
Key: WICKET-2091
URL: https://issues.apache.org/jira/browse/WICKET-2091
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.4, 1.4-RC3
Environment: Wicket 1.3.4 and Wicket SVN
Reporter: Ivo Danihelka
A DEBUG, INFO or WARNING feedback message hides a later added ERROR message.
The FeedbackMessages.hasErrorMessageFor() is unable to find it.
The problem is inside FeedbackMessages.hasMessageFor(component, level).
It checks only the first found message for the given component.
It should not stop on a message with a lower error level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2091) Error feedback is hidden by lower
level messages
Posted by "Oli Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oli Evans updated WICKET-2091:
------------------------------
Attachment: WICKET-2091-test2.patch
LWUG strikes again. Another unit test that shows up the same issue, but this time all in one class.
> Error feedback is hidden by lower level messages
> ------------------------------------------------
>
> Key: WICKET-2091
> URL: https://issues.apache.org/jira/browse/WICKET-2091
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-RC3
> Environment: Wicket 1.3.4 and Wicket SVN
> Reporter: Ivo Danihelka
> Attachments: WICKET-2091-test.txt, WICKET-2091-test2.patch, wicket-2190-fix.patch
>
>
> A DEBUG, INFO or WARNING feedback message hides a later added ERROR message.
> The FeedbackMessages.hasErrorMessageFor() is unable to find it.
> The problem is inside FeedbackMessages.hasMessageFor(component, level).
> It checks only the first found message for the given component.
> It should not stop on a message with a lower error level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2091) Error feedback is hidden by lower
level messages
Posted by "Charlie Dobbie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charlie Dobbie updated WICKET-2091:
-----------------------------------
Attachment: wicket-2190-fix.patch
Patch attached to fix issue. FeedbackMessages.hasMessageFor altered to cope with multiple messages.
> Error feedback is hidden by lower level messages
> ------------------------------------------------
>
> Key: WICKET-2091
> URL: https://issues.apache.org/jira/browse/WICKET-2091
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-RC3
> Environment: Wicket 1.3.4 and Wicket SVN
> Reporter: Ivo Danihelka
> Attachments: WICKET-2091-test.txt, wicket-2190-fix.patch
>
>
> A DEBUG, INFO or WARNING feedback message hides a later added ERROR message.
> The FeedbackMessages.hasErrorMessageFor() is unable to find it.
> The problem is inside FeedbackMessages.hasMessageFor(component, level).
> It checks only the first found message for the given component.
> It should not stop on a message with a lower error level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2091) Error feedback is hidden by lower
level messages
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2091.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4-RC3
1.3.6
Assignee: Igor Vaynberg
> Error feedback is hidden by lower level messages
> ------------------------------------------------
>
> Key: WICKET-2091
> URL: https://issues.apache.org/jira/browse/WICKET-2091
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-RC3
> Environment: Wicket 1.3.4 and Wicket SVN
> Reporter: Ivo Danihelka
> Assignee: Igor Vaynberg
> Fix For: 1.3.6, 1.4-RC3
>
> Attachments: WICKET-2091-test.txt, WICKET-2091-test2.patch, wicket-2190-fix.patch
>
>
> A DEBUG, INFO or WARNING feedback message hides a later added ERROR message.
> The FeedbackMessages.hasErrorMessageFor() is unable to find it.
> The problem is inside FeedbackMessages.hasMessageFor(component, level).
> It checks only the first found message for the given component.
> It should not stop on a message with a lower error level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2091) Error feedback is hidden by lower
level messages
Posted by "Charlie Dobbie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charlie Dobbie updated WICKET-2091:
-----------------------------------
Comment: was deleted
> Error feedback is hidden by lower level messages
> ------------------------------------------------
>
> Key: WICKET-2091
> URL: https://issues.apache.org/jira/browse/WICKET-2091
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-RC3
> Environment: Wicket 1.3.4 and Wicket SVN
> Reporter: Ivo Danihelka
> Attachments: WICKET-2091-test.txt, wicket-2190-fix.patch
>
>
> A DEBUG, INFO or WARNING feedback message hides a later added ERROR message.
> The FeedbackMessages.hasErrorMessageFor() is unable to find it.
> The problem is inside FeedbackMessages.hasMessageFor(component, level).
> It checks only the first found message for the given component.
> It should not stop on a message with a lower error level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2091) Error feedback is hidden by lower
level messages
Posted by "Charlie Dobbie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charlie Dobbie updated WICKET-2091:
-----------------------------------
Attachment: (was: wicket-2091.patch)
> Error feedback is hidden by lower level messages
> ------------------------------------------------
>
> Key: WICKET-2091
> URL: https://issues.apache.org/jira/browse/WICKET-2091
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-RC3
> Environment: Wicket 1.3.4 and Wicket SVN
> Reporter: Ivo Danihelka
> Attachments: WICKET-2091-test.txt
>
>
> A DEBUG, INFO or WARNING feedback message hides a later added ERROR message.
> The FeedbackMessages.hasErrorMessageFor() is unable to find it.
> The problem is inside FeedbackMessages.hasMessageFor(component, level).
> It checks only the first found message for the given component.
> It should not stop on a message with a lower error level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2091) Error feedback is hidden by lower
level messages
Posted by "Wille Faler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wille Faler updated WICKET-2091:
--------------------------------
Attachment: WICKET-2091-test.txt
I have attached a patch with unit-tests for this bug.
Given the code currently in SVN the test fails (as expected), however I think a patch fixing the issue is forthcoming from another source momentarily, after which the test should pass..
> Error feedback is hidden by lower level messages
> ------------------------------------------------
>
> Key: WICKET-2091
> URL: https://issues.apache.org/jira/browse/WICKET-2091
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-RC3
> Environment: Wicket 1.3.4 and Wicket SVN
> Reporter: Ivo Danihelka
> Attachments: WICKET-2091-test.txt, wicket-2091.patch
>
>
> A DEBUG, INFO or WARNING feedback message hides a later added ERROR message.
> The FeedbackMessages.hasErrorMessageFor() is unable to find it.
> The problem is inside FeedbackMessages.hasMessageFor(component, level).
> It checks only the first found message for the given component.
> It should not stop on a message with a lower error level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2091) Error feedback is hidden by lower
level messages
Posted by "Charlie Dobbie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charlie Dobbie updated WICKET-2091:
-----------------------------------
Attachment: wicket-2091.patch
Patch attached to fix issue. FeedbackMessages.hasMessageFor altered to cope with multiple messages.
> Error feedback is hidden by lower level messages
> ------------------------------------------------
>
> Key: WICKET-2091
> URL: https://issues.apache.org/jira/browse/WICKET-2091
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.4, 1.4-RC3
> Environment: Wicket 1.3.4 and Wicket SVN
> Reporter: Ivo Danihelka
> Attachments: wicket-2091.patch
>
>
> A DEBUG, INFO or WARNING feedback message hides a later added ERROR message.
> The FeedbackMessages.hasErrorMessageFor() is unable to find it.
> The problem is inside FeedbackMessages.hasMessageFor(component, level).
> It checks only the first found message for the given component.
> It should not stop on a message with a lower error level.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.