You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/08/18 22:33:37 UTC

[Bug 58261] New: [PATCH] Suppress messages written to System.out when running test suite

https://bz.apache.org/bugzilla/show_bug.cgi?id=58261

            Bug ID: 58261
           Summary: [PATCH] Suppress messages written to System.out when
                    running test suite
           Product: POI
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: POI Overall
          Assignee: dev@poi.apache.org
          Reporter: javenoneal@gmail.com

Created attachment 33012
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33012&action=edit
suppress ant test output patch

There are several tests that write the System.out when running "ant test",
including a hex dump of Container.dat from TestEscherDump. This output isn't
useful when running the entire test suite.

I've modified several tests to temporarily change System.out to a
NullOutputStream while the test is running to avoid this cruft. Is there a
better way to hide this output unless just one test case is executed instead of
the entire test suite?

I understand that there are some things that POI can't test for, such as if
Microsoft Office thinks a file is corrupted but POI doesn't have a problem
reading the file. There are several tests that write "Open <filename> in
Excel". Are these asking someone to manually open the files in Excel and verify
that the contents are displayed correctly? If so, perhaps we should have a
decoration for tests where manual verification of output files is required, and
the log should indicate what a person should look for in those files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 58261] [PATCH] Suppress messages written to System.out when running test suite

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58261

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 58261] [PATCH] Suppress messages written to System.out when running test suite

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58261

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 58261] [PATCH] Suppress messages written to System.out when running test suite

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58261

--- Comment #1 from Nick Burch <ap...@gagravarr.org> ---
On the whole, I don't think out tests should be outputting things to System.err
or System.out as they run, in the default config

However, I know there's some issues with getting the build to pass on at least
one of the continuous integration systems, so it might be that some of those
statements come from trying to track that down

There are some tests which output files for manual, visual checking. Those
won't be checked on every build, but probably should be checked periodically,
and especially before a release is done. If we could refactor things to make it
easier to see what could be manually checked, and what to look for, that'd be
great!

Maybe we could look at doing the manual check bits first, then blitz through
the other output ones when the entries relating to the problematic CI system
have been removed?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 58261] [PATCH] Suppress messages written to System.out when running test suite

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58261

--- Comment #2 from Javen O'Neal <on...@apache.org> ---
We could also find these by adding entries System.{out|err}.{print|println} to
src/resources/devtools/forbidden-apis-prod.txt

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org