[jira] [Resolved] (OAK-2894) RepositoryImpl should not manage the lifecycle of ContentRepository

["Alex Parvulescu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Parvulescu resolved OAK-2894.
----------------------------------
       Resolution: Not A Problem
    Fix Version/s:     (was: 1.3.5)

Closing as 'Not A Problem' based on the observation that the 2 instances are closely linked together.

This was noticed in our internal product where we've extended the RepositoryImpl and were still calling #close on an already closed repository, so we'll address this on our end.

> RepositoryImpl should not manage the lifecycle of ContentRepository
> -------------------------------------------------------------------
>
>                 Key: OAK-2894
>                 URL: https://issues.apache.org/jira/browse/OAK-2894
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: jcr
>    Affects Versions: 1.2.2
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>              Labels: modularization, resilience, technical_debt
>
> {{RepositoryImpl}} uses an instance of {{ContentRepository}} that is passed as an external dependency in its constructor.
> {{RepositoryImpl}} is not responsible for the creation of the {{ContentRepository}} instance and, as such, should not manage its lifecycle. In particular, the {{ContentRepository#close}} method should not be called when the {{RepositoryImpl#shutdown}} method is executed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)