You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/18 07:24:56 UTC
[GitHub] [incubator-dolphinscheduler] qmengss opened a new issue #4480: [Improvement][API] change method checkAdmin to isNotAdmin
qmengss opened a new issue #4480:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4480
*For better global communication, please give priority to using English description, thx! *
*Please review https://dolphinscheduler.apache.org/en-us/docs/development/issue.html when describe an issue.*
**Describe the question**
the method 'checkAdmin' in class 'BaseService' is to check user whether admin or not .
the comment of the method is 'true if administrator, otherwise false' , but the code logic means 'true if not administrator, otherwise false' , the comment and the code logic is not matching , change the method name and the comment helps to understand the function means.
**What are the current deficiencies and the benefits of improvement**
- It can make developers better understand the method
**Which version of DolphinScheduler:**
-[1.3.4]
**Describe alternatives you've considered**
change the method name from 'checkAdmin' to 'isNotAdmin' , also modify the usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs closed issue #4480: [Improvement][API] change method checkAdmin to isNotAdmin
Posted by GitBox <gi...@apache.org>.
CalvinKirs closed issue #4480:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on issue #4480: [Improvement][API] change method checkAdmin to isNotAdmin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #4480:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4480#issuecomment-762125792
close by #4483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zhuangchong commented on issue #4480: [Improvement][API] change method checkAdmin to isNotAdmin
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on issue #4480:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4480#issuecomment-762054146
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org