[GitHub] [cassandra] scottcarey commented on a change in pull request #1085: Allow nodetool garbagecollect to take a user defined list of SSTables

[GitBox <gi...@apache.org>]

scottcarey commented on a change in pull request #1085:
URL: https://github.com/apache/cassandra/pull/1085#discussion_r659263308



##########
File path: src/java/org/apache/cassandra/db/compaction/CompactionManager.java
##########
@@ -333,7 +337,7 @@ public Object call() throws Exception
                 }
             }
             FBUtilities.waitOnFutures(futures);
-            assert compacting.originals().isEmpty();
+            assert (compacting.originals().size() == originalCount - tableCount);

Review comment:
       this assert was incorrect.
   
   There is no unit test for 'nodetool relocatesstables'  but if there was, this assert would break there too.  Any operation that reduces the number of SSTables returned from `operation.filterSSTables` would break.  I assume the assert came from a time prior, when all operations were supposed to process every file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org