You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/07/01 21:48:08 UTC
[GitHub] [tvm] karljang opened a new pull request #8385: [ONNX] Wrap 'If' if it has multiple outputs
karljang opened a new pull request #8385:
URL: https://github.com/apache/tvm/pull/8385
Without this wrapper, an assertion in from_onnx() will fail with the
error message showing "Number of output mismatch"
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] karljang commented on pull request #8385: [ONNX] Wrap 'If' if it has multiple outputs
Posted by GitBox <gi...@apache.org>.
karljang commented on pull request #8385:
URL: https://github.com/apache/tvm/pull/8385#issuecomment-873303262
@jwfromm
Thanks for the link!
I just modified the current test case to cover multiple output cases~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #8385: [ONNX] Wrap 'If' if it has multiple outputs
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8385:
URL: https://github.com/apache/tvm/pull/8385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] karljang commented on pull request #8385: [ONNX] Wrap 'If' if it has multiple outputs
Posted by GitBox <gi...@apache.org>.
karljang commented on pull request #8385:
URL: https://github.com/apache/tvm/pull/8385#issuecomment-875818065
@jwfromm
Thank you! It was a pleasant, first commit for me, thanks to your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #8385: [ONNX] Wrap 'If' if it has multiple outputs
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #8385:
URL: https://github.com/apache/tvm/pull/8385#issuecomment-873275161
Thanks for this fix, it makes sense to me. Can you add a test case that triggers the previous error to `tests/python/frontend/onnx/test_forward.py`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] karljang commented on pull request #8385: [ONNX] Wrap 'If' if it has multiple outputs
Posted by GitBox <gi...@apache.org>.
karljang commented on pull request #8385:
URL: https://github.com/apache/tvm/pull/8385#issuecomment-874372445
@jwfromm
Fixed the formatting issues, thank you for your review and tips~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #8385: [ONNX] Wrap 'If' if it has multiple outputs
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #8385:
URL: https://github.com/apache/tvm/pull/8385#issuecomment-875796946
@karljang This is now merged. Thanks for taking the initiative to make this fix and congrats on your first commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] karljang commented on pull request #8385: [ONNX] Wrap 'If' if it has multiple outputs
Posted by GitBox <gi...@apache.org>.
karljang commented on pull request #8385:
URL: https://github.com/apache/tvm/pull/8385#issuecomment-874372445
@jwfromm
Fixed the formatting issues, thank you for your review and tips~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm edited a comment on pull request #8385: [ONNX] Wrap 'If' if it has multiple outputs
Posted by GitBox <gi...@apache.org>.
jwfromm edited a comment on pull request #8385:
URL: https://github.com/apache/tvm/pull/8385#issuecomment-873275161
Thanks for this fix, it makes sense to me. Can you add a test case that triggers the previous error to `tests/python/frontend/onnx/test_forward.py`? Take a look at [the current test for If](https://github.com/apache/tvm/blob/7b898d058cbabd922dc34476cd0ac3c0371c7a8d/tests/python/frontend/onnx/test_forward.py#L4120) and see if you can modify it to optionally have multiple outputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org