You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Mike Beckerle (Jira)" <ji...@apache.org> on 2019/11/01 00:06:00 UTC
[jira] [Created] (DAFFODIL-2226) MS Windows: unnecessarily
repetitive conditionalization in CLI/command-line-oriented tests
Mike Beckerle created DAFFODIL-2226:
---------------------------------------
Summary: MS Windows: unnecessarily repetitive conditionalization in CLI/command-line-oriented tests
Key: DAFFODIL-2226
URL: https://issues.apache.org/jira/browse/DAFFODIL-2226
Project: Daffodil
Issue Type: Improvement
Components: Clean Ups, QA
Affects Versions: 2.4.0
Reporter: Mike Beckerle
Fix For: 2.5.0
CLI tests, and tests of some features like UDFs are following a pattern which is unnecessarily redundant:
{code:java}
val schemaFile = Util.daffodilPath("daffodil-udf/src/test/resources/org/apache/daffodil/udf/genericUdfSchema.xsd")
val (testSchemaFile) = if (Util.isWindows) (Util.cmdConvert(schemaFile)) else (schemaFile)
{code}
Every file path used by every test has this explicit MS-Windows conditionalization in it. Over and over and over.
This should be replaced by things that combine what Util.daffodilPath and Util.cmdConvert do, so that all we require is that people construct a, for example, Util.filePath(....) object from a platform independent (i.e., "/" separated) path name. The fact that this requires MS-windows conditionalization should be hidden.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)