You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/03/16 01:22:22 UTC
[GitHub] [orc] wgtmac opened a new pull request, #1442: ORC-1395: Enforce license check via github action
wgtmac opened a new pull request, #1442:
URL: https://github.com/apache/orc/pull/1442
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1442: ORC-1395: Enforce license check via github action
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1442: ORC-1395: Enforce license check via github action
URL: https://github.com/apache/orc/pull/1442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1442: ORC-1395: Enforce license check via github action
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1442:
URL: https://github.com/apache/orc/pull/1442#issuecomment-1471136750
This PR is supposed to fail at C++ code, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #1442: ORC-1395: Enforce license check via github action
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1442:
URL: https://github.com/apache/orc/pull/1442#issuecomment-1471209519
The new action is now ready to go: https://github.com/apache/orc/actions/runs/4433068369/jobs/7777756717
I found that we have different license headers in the C++ source codes and use the tool to fix them in this PR.
I haven't fixed the two new files without license headers to make sure the tool works as below:
```
Run license-eye -v info -c .github/.licenserc.yaml header check
INFO Loading configuration from file: .github/.licenserc.yaml
INFO Totally checked 2062 files, valid: 157, invalid: 2, ignored: 1903, fixed: 0
ERROR the following files don't have a valid license header:
c++/src/SchemaEvolution.cc
c++/src/SchemaEvolution.hh
ERROR one or more files does not have a valid license header
Error: Process completed with exit code 1.
```
Once https://github.com/apache/orc/pull/1441 is merged, I can rebase and retrigger the action.
@dongjoon-hyun @coderex2522 @ffacs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1442: ORC-1395: Enforce license check via github action
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1442:
URL: https://github.com/apache/orc/pull/1442#issuecomment-1471265285
Merged to main.
Could you make a PR to branch-1.8 and branch-1.7, @wgtmac ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #1442: ORC-1395: Enforce license check via github action
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1442:
URL: https://github.com/apache/orc/pull/1442#issuecomment-1471137294
> This PR is supposed to fail at C++ code, right?
Give me some time to learn how to config it for C++ only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org