You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/12/09 06:54:34 UTC
Review Request 41119: Cleaned up DRF allocator tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41119/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Cleaned up DRF allocator tests.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp fb214a829a57529d3f5c49730ae9733f53e622ca
Diff: https://reviews.apache.org/r/41119/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 41119: Cleaned up DRF allocator tests.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41119/#review109461
-----------------------------------------------------------
Ship it!
src/tests/hierarchical_allocator_tests.cpp (line 30)
<https://reviews.apache.org/r/41119/#comment169011>
While we're here, it seems like `process::Shared` isn't used either.
- Michael Park
On Dec. 9, 2015, 5:54 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41119/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 5:54 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up DRF allocator tests.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp fb214a829a57529d3f5c49730ae9733f53e622ca
>
> Diff: https://reviews.apache.org/r/41119/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 41119: Cleaned up DRF allocator tests.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41119/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 8:01 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Cleaned up DRF allocator tests.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp fb214a829a57529d3f5c49730ae9733f53e622ca
Diff: https://reviews.apache.org/r/41119/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 41119: Cleaned up DRF allocator tests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41119/#review109487
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos ReviewBot
On Dec. 9, 2015, 5:54 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41119/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 5:54 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up DRF allocator tests.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp fb214a829a57529d3f5c49730ae9733f53e622ca
>
> Diff: https://reviews.apache.org/r/41119/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 41119: Cleaned up DRF allocator tests.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41119/#review109468
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Dec. 8, 2015, 9:54 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41119/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 9:54 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up DRF allocator tests.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp fb214a829a57529d3f5c49730ae9733f53e622ca
>
> Diff: https://reviews.apache.org/r/41119/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>