You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/13 01:56:42 UTC

[GitHub] [arrow] guyuqi commented on a change in pull request #9424: ARROW-11502: [C++] Optimize Arrow ByteStreamSplitDecode with Neon

guyuqi commented on a change in pull request #9424:
URL: https://github.com/apache/arrow/pull/9424#discussion_r631512360



##########
File path: cpp/src/arrow/util/byte_stream_split.h
##########
@@ -23,25 +23,33 @@
 #include <stdint.h>
 #include <algorithm>
 
+#if defined(ARROW_HAVE_NEON) || defined(ARROW_HAVE_SSE4_2)
+#include <xsimd/xsimd.hpp>
+// Enable the SIMD for ByteStreamSplit Decoder
+#define ARROW_HAVE_SIMD_DECODE_SPLIT
+#endif
+
 #ifdef ARROW_HAVE_SSE4_2

Review comment:
       Hi pitrou, thanks for your comments.
   
   I splited `ARROW_HAVE_SIMD_SPLIT` into `ARROW_HAVE_SIMD_DECODE_SPLIT` and `ARROW_HAVE_SIMD_ENCODE_SPLIT` which are used for `ByteStreamSplitDecode` and `ByteStreamSplitEncode` respectively.
   This PR is for ByteStreamSplitDecode, so not enabling `Encode ` here for Neon.
   
   How about to enable `Encode` and convert `ByteStreamSplitEncode` to xsimd in another PR and Jira? 
   Or, do you prefer putting everything in this single PR? 
   Thanks. :) 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org