You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2016/06/03 03:47:51 UTC
[GitHub] incubator-gearpump pull request #33: fix GEARPUMP-32, introduce source water...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/33
fix GEARPUMP-32, introduce source watermark
This PR introduces source watermark such that
1. messages with timestamps earlier than watermark could be filtered out at source.
2. minclock of source processor will be bounded by watemark
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump watermark
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit d3d6466a10a0475a9e83dd07d20e9b4d6c1bdb9e
Author: manuzhang <ow...@gmail.com>
Date: 2016-05-31T05:10:24Z
fix GEARPUMP-32, introduce source watermark
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #33: fix GEARPUMP-32, introduce source watermark
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/33
The PR is not mature and opened early to gather thoughts from the community.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #33: fix GEARPUMP-32, introduce source watermark
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/33
## [Current coverage][cc-pull] is **65.96%**
> Merging [#33][cc-pull] into [master][cc-base-branch] will increase coverage by **2.45%**
1. 5 files (not in diff) in `...rpump/streaming/task` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F7461736B)
1. 2 files (not in diff) in `...streaming/state/impl` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F73746174652F696D706C)
1. 2 files (not in diff) in `.../streaming/state/api` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F73746174652F617069)
1. 2 files (not in diff) in `...mp/streaming/metrics` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6D657472696373)
1. 2 files (not in diff) in `...p/streaming/executor` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6578656375746F72)
- Misses `-1`
- Hits `+1`
1. 2 files (not in diff) in `...p/streaming/dsl/plan` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F64736C2F706C616E)
1. 1 files (not in diff) in `...arpump/streaming/dsl` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F64736C)
1. 3 files (not in diff) in `.../streaming/appmaster` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6170706D6173746572)
1. 1 files (not in diff) in `...e/gearpump/streaming` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E67)
1. 2 files (not in diff) in `.../lib/source/consumer` were modified. [more](https://codecov.io/gh/apache/incubator-gearpump/commit/d88f6675bdf49f2a302dddfb5a05a00de3601531/changes?src=pr#65787465726E616C2F6B61666B612F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6B61666B612F6C69622F736F757263652F636F6E73756D6572)
```diff
@@ master #33 diff @@
==========================================
Files 178 178
Lines 5922 5929 +7
Methods 5644 5631 -13
Messages 0 0
Branches 278 298 +20
==========================================
+ Hits 3761 3911 +150
+ Misses 2161 2018 -143
Partials 0 0
```
[![Sunburst](https://codecov.io/gh/apache/incubator-gearpump/pull/33/graphs/sunburst.svg?src=pr&size=150)][cc-pull]
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [ec04cf7...d88f667][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/incubator-gearpump/compare/ec04cf7666020ba15764611ac872344549f5200c...d88f6675bdf49f2a302dddfb5a05a00de3601531
[cc-pull]: https://codecov.io/gh/apache/incubator-gearpump/pull/33?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #33: fix GEARPUMP-32, introduce source water...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---