You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/10 15:30:42 UTC

[GitHub] [airflow] OmerJog commented on issue #5077: [AIRFLOW-4268] Add MsSqlToGoogleCloudStorageOperator

OmerJog commented on issue #5077: [AIRFLOW-4268] Add MsSqlToGoogleCloudStorageOperator
URL: https://github.com/apache/airflow/pull/5077#issuecomment-481740191
 
 
   My 2 notes:
   1. I think it's better to support all the relevant argument of the hook. For example the operator introduced in this PR doesn't support the gzip flag of the  GoogleCloudStorageHook (reference https://github.com/apache/airflow/pull/3893 ) 
   
   2. PR https://github.com/apache/airflow/pull/5043 raised a question about the num_retries of the hook/operator. I didn't see the committers agree on course of action hopefully it will be done soon and this PR will be updated accordingly. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services