You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/01 07:21:19 UTC
[GitHub] [incubator-yunikorn-core] anuraagnalluri opened a new pull request #378: Full state dump REST call doesn't return anything
anuraagnalluri opened a new pull request #378:
URL: https://github.com/apache/incubator-yunikorn-core/pull/378
### What is this PR for?
Full state dumps were being incorrectly logged to the periodic state dump file. This PR parameterizes `doStateDump()` such that it's logs directly to stdout for full state dump or the state dump file for periodic state dumps.
### What type of PR is it?
* [X] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
### What is the Jira issue?
* https://issues.apache.org/jira/browse/YUNIKORN-1095
### How should this be tested?
Manual
### Screenshots (if appropriate)
<img width="1090" alt="Screen Shot 2022-02-28 at 11 20 32 PM" src="https://user-images.githubusercontent.com/15059525/156123115-1f2d9a03-baea-4f03-beb0-8b5e6e357045.png">
### Questions:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #378: [YUNIKORN-1095] Full state dump REST call doesn't return anything
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #378:
URL: https://github.com/apache/incubator-yunikorn-core/pull/378#issuecomment-1055133902
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#378](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/378?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e49785) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/dc98d22dac0197145c0884b9eb69347620c4a7f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc98d22) will **increase** coverage by `0.00%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 69.35% 69.35%
=======================================
Files 66 66
Lines 9354 9355 +1
=======================================
+ Hits 6487 6488 +1
Misses 2625 2625
Partials 242 242
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/webservice/state\_dump.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2Uvc3RhdGVfZHVtcC5nbw==) | `80.25% <81.81%> (+0.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/378?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/378?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dc98d22...7e49785](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/378?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] anuraagnalluri commented on pull request #378: Full state dump REST call doesn't return anything
Posted by GitBox <gi...@apache.org>.
anuraagnalluri commented on pull request #378:
URL: https://github.com/apache/incubator-yunikorn-core/pull/378#issuecomment-1055104725
@pbacsko @craigcondit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] anuraagnalluri edited a comment on pull request #378: [YUNIKORN-1095] Full state dump REST call doesn't return anything
Posted by GitBox <gi...@apache.org>.
anuraagnalluri edited a comment on pull request #378:
URL: https://github.com/apache/incubator-yunikorn-core/pull/378#issuecomment-1055104725
@pbacsko @craigcondit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] anuraagnalluri edited a comment on pull request #378: [YUNIKORN-1095] Full state dump REST call doesn't return anything
Posted by GitBox <gi...@apache.org>.
anuraagnalluri edited a comment on pull request #378:
URL: https://github.com/apache/incubator-yunikorn-core/pull/378#issuecomment-1055104725
@pbacsko @craigcondit -- Tagging you both for a sanity check to make sure I understood the ticket correctly. Still need to modify `handlers_test.go`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] pbacsko closed pull request #378: [YUNIKORN-1095] Full state dump REST call doesn't return anything
Posted by GitBox <gi...@apache.org>.
pbacsko closed pull request #378:
URL: https://github.com/apache/incubator-yunikorn-core/pull/378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org