You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/31 10:09:13 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3748: Systemvm template api

DaanHoogland commented on a change in pull request #3748: Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#discussion_r373403179
 
 

 ##########
 File path: test/integration/smoke/test_templates.py
 ##########
 @@ -735,8 +735,7 @@ def test_03_delete_template(self):
 
         list_template_response = Template.list(
                                     self.apiclient,
-                                    templatefilter=\
-                                    self.services["templatefilter"],
+                                    templatefilter='selfexecutable',
 
 Review comment:
   alarm bells are ringing in my ear when I see this, can you explain @Spaceman1984 ? we are no longer filtering according to the configured filter, but now hardcoding the filter type?!?!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services