You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "giacomocariello (via GitHub)" <gi...@apache.org> on 2025/03/06 18:13:52 UTC
[PR] feat: flake.nix for nix build support. [iggy]
giacomocariello opened a new pull request, #1613:
URL: https://github.com/apache/iggy/pull/1613
This PR implements flake.nix and adapts a few build files to comply with "rust-flake" package requirements.
Default package is set to build server crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: flake.nix for nix build support. [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #1613:
URL: https://github.com/apache/iggy/pull/1613#issuecomment-2911638223
@giacomocariello @martin-g how can we proceed here? no one from dev team uses nix daily, and we don't have any chances to verify this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: flake.nix for nix build support. [iggy]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #1613:
URL: https://github.com/apache/iggy/pull/1613#discussion_r2065732533
##########
flake.nix:
##########
@@ -0,0 +1,57 @@
+{
+ description = "iggy-rs";
+ inputs = {
+ nixpkgs.url = "github:cachix/devenv-nixpkgs/rolling";
+ systems.url = "github:nix-systems/default";
+ flake-parts.url = "github:hercules-ci/flake-parts";
+ devshell.url = "github:numtide/devshell";
+ rust-overlay = {
+ url = "github:oxalica/rust-overlay";
+ inputs.nixpkgs.follows = "nixpkgs";
+ };
+ rust-flake = {
+ url = "github:juspay/rust-flake";
+ inputs.rust-overlay.follows = "rust-overlay";
+ };
+ };
+
+ outputs = inputs@{ nixpkgs, rust-overlay, ... }:
+ inputs.flake-parts.lib.mkFlake { inherit inputs; } {
+ systems = import inputs.systems;
+
+ imports = [
+ inputs.rust-flake.flakeModules.default
+ inputs.rust-flake.flakeModules.nixpkgs
+ ];
+
+ flake = {
+ nix-health.default = {
+ nix-version.min-required = "2.16.0";
+ direnv.required = true;
+ };
+ };
+
+ perSystem = { config, self', pkgs, lib, system, ... }: {
+ devShells.default = pkgs.mkShell {
+ inputsFrom = [
+ self'.devShells.rust
+ ];
Review Comment:
nit: the indentation is off from here on. It would be nice if it is corrected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: flake.nix for nix build support. [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio closed pull request #1613: feat: flake.nix for nix build support.
URL: https://github.com/apache/iggy/pull/1613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: flake.nix for nix build support. [iggy]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1613:
URL: https://github.com/apache/iggy/pull/1613#issuecomment-2911717316
Option 1) is to accept the PR and add a comment on top of the .nix file that the repo maintainers do not use NixOS and that they depend on the community to maintain this file.
Option 2) reject the PR explaining that this file should be maintained by a third-party.
My 2c!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org