[GitHub] [arrow] pitrou commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS

["pitrou (via GitHub)" <gi...@apache.org>]

pitrou commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1195253695


##########
java/Brewfile:
##########
@@ -17,3 +17,4 @@
 
 brew "openjdk@11"
 brew "sccache"
+brew "curl"

Review Comment:
   Perhaps keep this file in alphabetical order?



##########
cpp/build-support/run-test.sh:
##########
@@ -60,6 +60,9 @@ rm -f $LOGFILE $LOGFILE.gz
 
 pipe_cmd=cat
 
+# Install the gcs testbench
+sh $ROOT/../ci/scripts/install_gcs_testbench.sh default

Review Comment:
   I don't think we should add this here. Why do you need this change?



##########
ci/scripts/java_jni_macos_build.sh:
##########
@@ -75,15 +77,18 @@ cmake \
   -DARROW_DEPENDENCY_USE_SHARED=OFF \
   -DARROW_GANDIVA=${ARROW_GANDIVA} \
   -DARROW_GANDIVA_STATIC_LIBSTDCPP=ON \
+  -DARROW_GCS=${ARROW_GCS} \
   -DARROW_ORC=${ARROW_ORC} \
   -DARROW_PARQUET=${ARROW_PARQUET} \
   -DARROW_S3=${ARROW_S3} \
   -DARROW_USE_CCACHE=${ARROW_USE_CCACHE} \
+  -DARROW_WITH_SNAPPY=ON \

Review Comment:
   Why does Snappy need to be enabled here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org