[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7027: Make the number of core worker in meter converter thread pool config…

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #7027:
URL: https://github.com/apache/skywalking/pull/7027#discussion_r640410384



##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -337,7 +337,9 @@ envoy-metric:
 prometheus-fetcher:
   selector: ${SW_PROMETHEUS_FETCHER:-}
   default:
+    active: ${SW_PROMETHEUS_FETCHER_ACTIVE:false}
     enabledRules: ${SW_PROMETHEUS_FETCHER_ENABLED_RULES:"self"}
+    maxConvertWorker: ${SW_PROMETHEUS_FETCHER_NUM_CONVERT_WORKER:-}

Review comment:
       I don't think we support `-` in these config items (only `selector` supports `-` I think)

##########
File path: oap-server/server-fetcher-plugin/prometheus-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/fetcher/prometheus/provider/PrometheusFetcherConfig.java
##########
@@ -28,13 +28,15 @@
 
 @Getter
 public class PrometheusFetcherConfig extends ModuleConfig {
+
+    private int meterConvertWorker = Runtime.getRuntime().availableProcessors() / 2;

Review comment:
       the field name is different with the one in config file
   
   
   ```diff
   - meterConvertWorker
   + maxConvertWorker
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org