You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/09 19:28:38 UTC

[GitHub] kristw commented on issue #5549: Add additional heatmap schemas

kristw commented on issue #5549: Add additional heatmap schemas
URL: https://github.com/apache/incubator-superset/pull/5549#issuecomment-411869964
 
 
   LGTM. I agree with @williaster 
   @jerowe I would recommend squashing your git commits and clean the commit messages a little bit as these messages will forever be stored in the main repo git log. 
   https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org