You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by li...@apache.org on 2014/02/14 20:18:24 UTC
svn commit: r1568490 -
/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
Author: liyin
Date: Fri Feb 14 19:18:23 2014
New Revision: 1568490
URL: http://svn.apache.org/r1568490
Log:
[HBASE-9896] Fix the end row bug in the TableInputFormatBase
Author: rshroff
Summary:
In case the the endrow is not specified, the end row is taken from the
HexSplit Class, which defaults it to 'ffffffff'. This will exclude all
the rows starting with ffffffff and after. The fix honors the endrow
from the config instead of using the one from the HexSplit Class.
Test Plan: MR unit tests, and custom job
Reviewers: manukranthk, liyintang
Reviewed By: manukranthk
CC: hbase-dev@, syyang, chaoyc
Differential Revision: https://phabricator.fb.com/D1171876
Task ID: 3599597
Modified:
hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java?rev=1568490&r1=1568489&r2=1568490&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java Fri Feb 14 19:18:23 2014
@@ -254,8 +254,8 @@ extends InputFormat<ImmutableBytesWritab
// This will return numMappersPerJob - 1 split interval
byte[][] dividingKeys = algmImpl.split(numMappersPerJob);
- byte[] splitStartKey = algmImpl.firstRow();
- byte[] splitStopKey = algmImpl.lastRow();
+ byte[] splitStartKey = startRow;
+ byte[] splitStopKey = stopRow;
TreeMap<byte[], byte[]> regions = table.getStartEndKeysMap();
@@ -273,7 +273,7 @@ extends InputFormat<ImmutableBytesWritab
} else {
for (int i = 0; i <= dividingKeys.length; i++) {
if (i == dividingKeys.length) {
- splitStopKey = algmImpl.lastRow();
+ splitStopKey = stopRow;
} else {
splitStopKey = dividingKeys[i];
}