You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/01/03 03:23:49 UTC
Review Request 41857: [WIP][MESOS-3892] get evictable executors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/
-----------------------------------------------------------
Review request for mesos and Guangya Liu.
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
get evictable executors
Diffs
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41857/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41857: [MESOS-3892] get evictable executors
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 8:41 p.m.)
Review request for mesos and Guangya Liu.
Changes
-------
Add `idle` for the allocation slack which's not used by others.
Summary (updated)
-----------------
[MESOS-3892] get evictable executors
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
get evictable executors
Diffs (updated)
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41857/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41857: [WIP][MESOS-3892] get evictable executors
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/#review112440
-----------------------------------------------------------
src/slave/slave.cpp (line 3974)
<https://reviews.apache.org/r/41857/#comment172909>
It should use idle (total - pending - occupied) to check
- Klaus Ma
On Jan. 3, 2016, 10:23 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41857/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 10:23 a.m.)
>
>
> Review request for mesos and Guangya Liu.
>
>
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> get evictable executors
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
>
> Diff: https://reviews.apache.org/r/41857/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41857: Got evictable executors.
Posted by Klaus Ma <kl...@gmail.com>.
> On Jan. 4, 2016, 4:21 p.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 3954
> > <https://reviews.apache.org/r/41857/diff/1/?file=1180472#file1180472line3954>
> >
> > Here should be requested.stateless().reserved()
Using `allocationSlackable` for `stateless().reserved()`.
> On Jan. 4, 2016, 4:21 p.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 4008
> > <https://reviews.apache.org/r/41857/diff/1/?file=1180472#file1180472line4008>
> >
> > What about using following to get evictable executors?
> >
> > if (availabe-occupied+evicting).contains(reserved)
> > wait for executor terminated future
> > else:
> > evcit some executors
`available` may not contains `occupied`.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/#review112516
-----------------------------------------------------------
On Jan. 9, 2016, 5:06 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41857/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 5:06 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> get evictable executors
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41857/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41857: [WIP][MESOS-3892] get evictable executors
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41857/#review112516
-----------------------------------------------------------
src/slave/slave.hpp (lines 374 - 376)
<https://reviews.apache.org/r/41857/#comment172983>
period to the end.
src/slave/slave.cpp (line 3954)
<https://reviews.apache.org/r/41857/#comment172987>
Here should be requested.stateless().reserved()
src/slave/slave.cpp (line 3974)
<https://reviews.apache.org/r/41857/#comment172988>
I think that we can ignore the eviciting executors here, just check if the available minus occupied does not contain allocationSlack, reutn error. The revocable tasks can be treated as low priority and no need make it pending for resources, comments?
src/slave/slave.cpp (lines 3978 - 3983)
<https://reviews.apache.org/r/41857/#comment172989>
Why evict executor for revocable tasks?
src/slave/slave.cpp (line 4008)
<https://reviews.apache.org/r/41857/#comment172991>
What about using following to get evictable executors?
if (availabe-occupied+evicting).contains(reserved)
wait for executor terminated future
else:
evcit some executors
- Guangya Liu
On Jan. 3, 2016, 2:23 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41857/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 2:23 a.m.)
>
>
> Review request for mesos and Guangya Liu.
>
>
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> get evictable executors
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
>
> Diff: https://reviews.apache.org/r/41857/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>