[GitHub] justinborromeo commented on a change in pull request #7012: Improve druid.storage.sse.kms.keyId and druid.s3.protocol

[GitBox <gi...@apache.org>]

justinborromeo commented on a change in pull request #7012: Improve druid.storage.sse.kms.keyId and druid.s3.protocol
URL: https://github.com/apache/incubator-druid/pull/7012#discussion_r254102154
 
 

 ##########
 File path: docs/content/development/extensions-core/s3.md
 ##########
 @@ -47,9 +47,9 @@ As an example, to set the region to 'us-east-1' through system properties:
 |`druid.storage.baseKey`|Base key prefix to use, i.e. what directory.|Must be set.|
 |`druid.storage.disableAcl`|Boolean flag to disable ACL. If this is set to `false`, the full control would be granted to the bucket owner. This may require to set additional permissions. See [S3 permissions settings](#s3-permissions-settings).|false|
 |`druid.storage.sse.type`|Server-side encryption type. Should be one of `s3`, `kms`, and `custom`. See the below [Server-side encryption section](#server-side-encryption) for more details.|None|
-|`druid.storage.sse.kms.keyId`|AWS KMS key ID. Can be empty if `druid.storage.sse.type` is `kms`.|None|
+|`druid.storage.sse.kms.keyId`|AWS KMS key ID. This is used only when `druid.storage.sse.type` is `kms` and can be empty to use the default key ID.|None|
 |`druid.storage.sse.custom.base64EncodedKey`|Base64-encoded key. Should be specified if `druid.storage.sse.type` is `custom`.|None|
-|`druid.s3.protocol`|Communication protocol type to use when sending requests to AWS. `http` or `https` can be used.|`https`|
+|`druid.s3.protocol`|Communication protocol type to use when sending requests to AWS. `http` or `https` can be used. This configuration would be ignored if `druid.s3.endpoint.url` is filled with an URL with a different protocol.|`https`|
 
 Review comment:
   nit - "an URL" would probably be better as "a URL"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org