[GitHub] [skywalking] mritd commented on issue #6611: [helm] helm installation fails when using H2 database

[GitBox <gi...@apache.org>]

mritd commented on issue #6611:
URL: https://github.com/apache/skywalking/issues/6611#issuecomment-805667669


   @wu-sheng @kezhenxu94 Please reopen this issue.
   
   After reviewing the code, a bug was introduced in recent https://github.com/apache/skywalking-kubernetes/commit/31898203dceba00550cf78eb5ce979efea562587 commit:
   
   "volumeMounts" and other options were not included in the `{{- if hasPrefix "elasticsearch" .Values.oap.storageType }}` check, which would lead to use Installation of other storage backends failed.
   
   ```diff
   {{- if hasPrefix "elasticsearch" .Values.oap.storageType }}
   apiVersion: batch/v1
   kind: Job
   metadata:
   .......
           {{- range $key, $value :=  .Values.oap.env }}
           - name: {{ $key }}
             value: {{ $value | quote }}
           {{- end }}
   {{- end}}
   +        volumeMounts:
   +          {{- if (.Files.Glob "files/conf.d/oap/**") }}
   +            {{ range $path, $bytes := .Files.Glob "files/conf.d/oap/**" }}
   +            - name: skywalking-oap-override
   +              mountPath: {{ print "/skywalking/config/" ($path | replace "files/conf.d/oap/" "") }}
   +              subPath: {{ $path | replace "files/conf.d/oap/" "" | b64enc | replace "=" "-" }}
   +            {{- end }}
   +            {{- end }}
   +      volumes:
   +        {{- if (.Files.Glob "files/conf.d/oap/**") }}
   +        - name: skywalking-oap-override
   +          configMap:
   +            name: {{ template "skywalking.fullname" . }}-oap-cm-override
   +        {{- end }}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org