You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/01 06:46:44 UTC

[GitHub] [airflow] vikramcse opened a new pull request #14001: added missing return parameter in read function of FileTaskHandler

vikramcse opened a new pull request #14001:
URL: https://github.com/apache/airflow/pull/14001


   this issue occurs when invalid try_number value is passed in get logs api
   FIXES: #13638


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14001: added missing return parameter in read function of FileTaskHandler

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #14001:
URL: https://github.com/apache/airflow/pull/14001#issuecomment-770614783

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek merged pull request #14001: added missing return parameter in read function of FileTaskHandler

Posted by GitBox <gi...@apache.org>.

turbaszek merged pull request #14001:
URL: https://github.com/apache/airflow/pull/14001


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #14001: added missing return parameter in read function of FileTaskHandler

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #14001:
URL: https://github.com/apache/airflow/pull/14001#issuecomment-770772178


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14001: added missing return parameter in read function of FileTaskHandler

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #14001:
URL: https://github.com/apache/airflow/pull/14001#issuecomment-770859840


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] vikramcse commented on pull request #14001: added missing return parameter in read function of FileTaskHandler

Posted by GitBox <gi...@apache.org>.

vikramcse commented on pull request #14001:
URL: https://github.com/apache/airflow/pull/14001#issuecomment-770851475


   @turbaszek what should be my next step? I can see the `please reabse or ammed` ci build is still running
   thank you


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on a change in pull request #14001: added missing return parameter in read function of FileTaskHandler

Posted by GitBox <gi...@apache.org>.

turbaszek commented on a change in pull request #14001:
URL: https://github.com/apache/airflow/pull/14001#discussion_r567736120



##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -207,7 +207,7 @@ def read(self, task_instance, try_number=None, metadata=None):
             logs = [
                 [('default_host', f'Error fetching the logs. Try number {try_number} is invalid.')],
             ]
-            return logs
+            return logs, [{'end_of_log': True}]

Review comment:
       This is interesting because such error should be spotted by `pylint` as inconsistent return statement. I think this is yet another time when I have a feeling that our pylint may not work perfectly well. CC @kaxil @ashb @potiuk 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org