You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/02 19:56:00 UTC
[jira] [Work logged] (BEAM-6339) In certain cases, spotlessJava
fails to work
[ https://issues.apache.org/jira/browse/BEAM-6339?focusedWorklogId=180388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-180388 ]
ASF GitHub Bot logged work on BEAM-6339:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jan/19 19:55
Start Date: 02/Jan/19 19:55
Worklog Time Spent: 10m
Work Description: HuangLED commented on pull request #7390: [BEAM-6339] Add paddedcell fix to spotlessJava rules.
URL: https://github.com/apache/beam/pull/7390
SpotlessJava fails to work when certain format issue exists in new code.
Plugin has official page refering to this issue with a fix, details see: https://github.com/diffplug/spotless/blob/master/PADDEDCELL.md
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 180388)
Time Spent: 10m
Remaining Estimate: 0h
> In certain cases, spotlessJava fails to work
> --------------------------------------------
>
> Key: BEAM-6339
> URL: https://issues.apache.org/jira/browse/BEAM-6339
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Trivial
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Encounter following error when certain criteria exists in new code:
>
> > Task :beam-runners-google-cloud-dataflow-java:spotlessJava FAILED
>
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':beam-runners-google-cloud-dataflow-java:spotlessJava'.
> > You have a misbehaving rule which can't make up its mind.
> This means that spotlessCheck will fail even after spotlessApply has run.
>
> This is a bug in a formatting rule, not Spotless itself, but Spotless can
> work around this bug and generate helpful bug reports for the broken rule
> if you add 'paddedCell()' to your build.gradle as such:
>
> spotless {
> format 'someFormat', {
> ...
> paddedCell()
> }
> }
>
> The next time you run spotlessCheck, it will put helpful bug reports into
> 'runners/google-cloud-dataflow-java/build/spotless-diagnose-java', and spotlessApply
> and spotlessCheck will be self-consistent from here on out.
>
> For details see [https://github.com/diffplug/spotless/blob/master/PADDEDCELL.md]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)