You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/20 11:57:45 UTC
[GitHub] [apisix-docker] tokers commented on a change in pull request #134: docs: improve the documentation of alpine
tokers commented on a change in pull request #134:
URL: https://github.com/apache/apisix-docker/pull/134#discussion_r579647176
##########
File path: alpine/README.MD
##########
@@ -1,5 +1,7 @@
### When building with `alpine` basic image, please specify `APISIX_VERSION` through `build-arg`
```
-docker build --build-arg APISIX_VERSION=$APISIX_VERSION -t $IMAGE_NAME .
-```
\ No newline at end of file
+$ docker build --build-arg APISIX_VERSION=$APISIX_VERSION -t $IMAGE_NAME .
+```
+
+Note: The minimum version of docker that supports building image is `docker 17.05.0-ce`.
Review comment:
Just add a warning message is enough such as "if you occur errors like blah blah blah, please upgrade your docker version".
##########
File path: alpine/README.MD
##########
@@ -1,5 +1,7 @@
### When building with `alpine` basic image, please specify `APISIX_VERSION` through `build-arg`
```
Review comment:
Add language specifier `shell`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org