You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Alchuang22-dev (via GitHub)" <gi...@apache.org> on 2025/09/28 09:47:41 UTC

[PR] [AINode] Fix: remove venv out of the target directory. [iotdb]

Alchuang22-dev opened a new pull request, #16511:
URL: https://github.com/apache/iotdb/pull/16511

   ## Description
   
   Make a hotfix to the bug that `venv` for ainode would be put in the distribution package in 2.0.6-SNAPSHOT. If this fix is applied, the size of ainode package will decrease to 346mb.
   Since the pull request did not change any pom file, several fixes will be pushed in few days.
    
   This PR has:
   - [x] been self-reviewed.
       - [x] concurrent read
       - [x] concurrent write
       - [x] concurrent read and write 
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. 
   - [ ] added or updated version, __license__, or notice information
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious 
     for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold 
     for code coverage.
   - [ ] added integration tests.
   - [ ] been tested in a test IoTDB cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AINode] Fix: remove venv out of the target directory. [iotdb]

Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula merged PR #16511:
URL: https://github.com/apache/iotdb/pull/16511


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AINode] Fix: remove venv out of the target directory. [iotdb]

Posted by "Alchuang22-dev (via GitHub)" <gi...@apache.org>.
Alchuang22-dev commented on code in PR #16511:
URL: https://github.com/apache/iotdb/pull/16511#discussion_r2394294412


##########
iotdb-core/ainode/pyproject.toml:
##########
@@ -100,7 +117,8 @@ black = "25.1.0"
 isort = "6.0.1"
 
 [tool.poetry.scripts]
+# 如果你的入口确实在 iotdb/ainode/core/script.py,请改回:

Review Comment:
   Sure, the comments has been reverted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AINode] Fix: remove venv out of the target directory. [iotdb]

Posted by "ycycse (via GitHub)" <gi...@apache.org>.
ycycse commented on code in PR #16511:
URL: https://github.com/apache/iotdb/pull/16511#discussion_r2386837120


##########
distribution/src/assembly/ainode.xml:
##########
@@ -30,20 +30,48 @@
         <fileSet>
             <directory>${project.basedir}/../iotdb-core/ainode/target/apache-iotdb-ainode-${project.version}/apache-iotdb-ainode-${project.version}/conf</directory>
             <outputDirectory>${file.separator}/conf</outputDirectory>
+            <excludes>
+                <exclude>venv/**</exclude>
+                <exclude>.venv/**</exclude>
+                <exclude>target/**</exclude>
+                <exclude>**/__pycache__/**</exclude>
+                <exclude>**/*.pyc</exclude>
+            </excludes>

Review Comment:
   Will venv exist under conf folder? Maybe we can make it more clear.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AINode] Fix: remove venv out of the target directory. [iotdb]

Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula commented on code in PR #16511:
URL: https://github.com/apache/iotdb/pull/16511#discussion_r2390454920


##########
iotdb-core/ainode/pyproject.toml:
##########
@@ -100,7 +117,8 @@ black = "25.1.0"
 isort = "6.0.1"
 
 [tool.poetry.scripts]
+# 如果你的入口确实在 iotdb/ainode/core/script.py,请改回:

Review Comment:
   Revert this.



##########
iotdb-core/ainode/pyproject.toml:
##########
@@ -14,7 +14,7 @@
 #  KIND, either express or implied.  See the License for the
 #  specific language governing permissions and limitations
 #  under the License.
-#
+

Review Comment:
   Revert this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org