You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/02 07:25:59 UTC

Review Request 13216: Refactored slave recovery so that slave recovers its state before the isolator and status update manager.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13216/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Bugs: MESOS-611
    https://issues.apache.org/jira/browse/MESOS-611


Repository: mesos-git


Description
-------

Slave recovering first ensures that any messages sent by the status update manager and isolator can be properly handled.


Diffs
-----

  src/slave/slave.hpp 97f2083db0dec2c1c9415f65d9bf8a834653bd18 
  src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04 

Diff: https://reviews.apache.org/r/13216/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 13216: Refactored slave recovery so that slave recovers its state before the isolator and status update manager.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13216/#review24554
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Aug. 2, 2013, 5:27 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13216/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 5:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-611
>     https://issues.apache.org/jira/browse/MESOS-611
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Slave recovering first ensures that any messages sent by the status update manager and isolator can be properly handled.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 97f2083db0dec2c1c9415f65d9bf8a834653bd18 
>   src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04 
> 
> Diff: https://reviews.apache.org/r/13216/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 13216: Refactored slave recovery so that slave recovers its state before the isolator and status update manager.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13216/#review24556
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Aug. 2, 2013, 5:27 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13216/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 5:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-611
>     https://issues.apache.org/jira/browse/MESOS-611
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Slave recovering first ensures that any messages sent by the status update manager and isolator can be properly handled.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 97f2083db0dec2c1c9415f65d9bf8a834653bd18 
>   src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04 
> 
> Diff: https://reviews.apache.org/r/13216/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 13216: Refactored slave recovery so that slave recovers its state before the isolator and status update manager.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13216/
-----------------------------------------------------------

(Updated Aug. 3, 2013, 8:32 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

rebased. nnfr.


Bugs: MESOS-611
    https://issues.apache.org/jira/browse/MESOS-611


Repository: mesos-git


Description
-------

Slave recovering first ensures that any messages sent by the status update manager and isolator can be properly handled.


Diffs (updated)
-----

  src/slave/slave.hpp 97f2083db0dec2c1c9415f65d9bf8a834653bd18 
  src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04 

Diff: https://reviews.apache.org/r/13216/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 13216: Refactored slave recovery so that slave recovers its state before the isolator and status update manager.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13216/
-----------------------------------------------------------

(Updated Aug. 2, 2013, 5:27 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

added dependency.


Bugs: MESOS-611
    https://issues.apache.org/jira/browse/MESOS-611


Repository: mesos-git


Description
-------

Slave recovering first ensures that any messages sent by the status update manager and isolator can be properly handled.


Diffs
-----

  src/slave/slave.hpp 97f2083db0dec2c1c9415f65d9bf8a834653bd18 
  src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04 

Diff: https://reviews.apache.org/r/13216/diff/


Testing
-------

make check


Thanks,

Vinod Kone