[GitHub] [airflow] uranusjr commented on a diff in pull request #27319: XCOM push ORA error code in OracleStoredProcedure

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #27319:
URL: https://github.com/apache/airflow/pull/27319#discussion_r1007791853


##########
airflow/providers/oracle/operators/oracle.py:
##########
@@ -93,4 +95,10 @@ def __init__(
     def execute(self, context: Context):
         self.log.info("Executing: %s", self.procedure)
         hook = OracleHook(oracle_conn_id=self.oracle_conn_id)
-        return hook.callproc(self.procedure, autocommit=True, parameters=self.parameters)
+        ti=context.get('task_instance')
+        try:
+            return hook.callproc(self.procedure, autocommit=True, parameters=self.parameters)
+        except oracledb.DatabaseError as e:
+            code, mesg = e.args[0].message[:-1].split(': ', 1)
+            ti.xcom_push(key='ORA', value=str(code.split('-')[1]))
+            raise AirflowException(f"Task failed with exit code: {code}")

Review Comment:
   Instead of coercing the exception to AirflowException, I would prefer this to simply re-raise the original exception:
   
   ```suggestion
               raise
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org