You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/06 08:56:37 UTC
[GitHub] zentol closed pull request #6486: [FLINK-10051][tests][sql] Add
missing depenendeices for sql client E2E test
zentol closed pull request #6486: [FLINK-10051][tests][sql] Add missing depenendeices for sql client E2E test
URL: https://github.com/apache/flink/pull/6486
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/flink-end-to-end-tests/flink-sql-client-test/pom.xml b/flink-end-to-end-tests/flink-sql-client-test/pom.xml
index 46bc2bac50c..ec5a0e10360 100644
--- a/flink-end-to-end-tests/flink-sql-client-test/pom.xml
+++ b/flink-end-to-end-tests/flink-sql-client-test/pom.xml
@@ -42,8 +42,67 @@ under the License.
<artifactId>scala-compiler</artifactId>
<scope>provided</scope>
</dependency>
+
+ <!-- The following dependencies are for connector/format sql-jars that
+ we copy using the maven-dependency-plugin. When extending the test
+ to cover more connectors/formats, add a dependency here and an entry
+ to the dependency-plugin configuration below.
+ This ensures that all modules we actually need (as defined by the
+ dependency-plugin configuration) are built before this module. -->
+ <dependency>
+ <!-- Used by maven-dependency-plugin -->
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-avro</artifactId>
+ <version>${project.version}</version>
+ <classifier>sql-jar</classifier>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <!-- Used by maven-dependency-plugin -->
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-json</artifactId>
+ <version>${project.version}</version>
+ <classifier>sql-jar</classifier>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <!-- Used by maven-dependency-plugin -->
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka-0.9_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <classifier>sql-jar</classifier>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <!-- Used by maven-dependency-plugin -->
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka-0.10_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <classifier>sql-jar</classifier>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <!-- Used by maven-dependency-plugin -->
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka-0.11_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <classifier>sql-jar</classifier>
+ <scope>provided</scope>
+ </dependency>
</dependencies>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <!-- Pick an arbitrary version here to satisfy the enforcer-plugin,
+ as we neither access nor package the kafka dependencies -->
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka-clients</artifactId>
+ <version>0.11.0.2</version>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
+
<build>
<plugins>
<!-- Build toolbox jar. -->
@@ -76,7 +135,9 @@ under the License.
</goals>
<configuration>
<outputDirectory>${project.build.directory}/sql-jars</outputDirectory>
- <!-- List of currently provided SQL jars. -->
+ <!-- List of currently provided SQL jars.
+ When extending this list please also add a dependency
+ for the respective module. -->
<artifactItems>
<artifactItem>
<groupId>org.apache.flink</groupId>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services