[GitHub] [doris] kaijchen commented on a diff in pull request #21746: [feature](partial update) add failure tolerance for strict mode partial update stream load

["kaijchen (via GitHub)" <gi...@apache.org>]

kaijchen commented on code in PR #21746:
URL: https://github.com/apache/doris/pull/21746#discussion_r1265621462


##########
be/src/olap/rowset/beta_rowset_writer.h:
##########
@@ -240,6 +243,8 @@ class BetaRowsetWriter : public RowsetWriter {
 
     int64_t _delete_bitmap_ns = 0;
     int64_t _segment_writer_ns = 0;
+
+    DeltaWriter* _delta_writer = nullptr;

Review Comment:
   We should not expose delta writer in rowset writer.



##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -890,6 +890,10 @@ Status BetaRowsetWriter::_flush_segment_writer(std::unique_ptr<segment_v2::Segme
     segstat.index_size = index_size + (*writer)->get_inverted_index_file_size();
     segstat.key_bounds = key_bounds;
 
+    if (_delta_writer != nullptr) {
+        _delta_writer->update_filtered_rows((*writer)->num_rows_filtered());

Review Comment:
   You should store this value in rowset writer and get it from delta writer instead.
   i.e. Call `rowset_writer->get_num_rows_filtered()` in DeltaWriter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org