You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "merlimat (via GitHub)" <gi...@apache.org> on 2026/03/20 17:03:29 UTC
[PR] [fix][test] Fix thread leaks in ClientDeduplicationFailureTest and RackAwareTest [pulsar]
merlimat opened a new pull request, #25374:
URL: https://github.com/apache/pulsar/pull/25374
## Summary
- **ClientDeduplicationFailureTest**: `shutdown()` was setting `pulsar = null` instead of `pulsarClient = null`, preventing PulsarService from being closed and leaking all broker threads (75 threads).
- **RackAwareTest**: Cleanup was stopping the ZK server before shutting down bookie ServerTesters, causing bookies' ZK clients to spawn reconnect threads (`ZKC-connect-executor`) that never terminated. Fixed by reversing the cleanup order.
## Documentation
- [ ] `doc-required`
- [x] `doc-not-needed`
- [ ] `doc-complete`
## Matching PR in forked repository
_none_
### Documentation Checklist
- [x] This PR does not require documentation changes
---
> [!NOTE]
> Ready to test
_Labels: `area/test`_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix thread leaks in ClientDeduplicationFailureTest and RackAwareTest [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25374:
URL: https://github.com/apache/pulsar/pull/25374#issuecomment-4101168069
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/25374?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 72.73%. Comparing base ([`a3ae705`](https://app.codecov.io/gh/apache/pulsar/commit/a3ae70545f3aef40e8f5cfcced907e6500b08894?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1237768`](https://app.codecov.io/gh/apache/pulsar/commit/1237768c0e9c248731eb442d44af42d38ba7cddc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/25374?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #25374 +/- ##
============================================
+ Coverage 72.52% 72.73% +0.20%
+ Complexity 34275 34249 -26
============================================
Files 1927 1954 +27
Lines 154339 154792 +453
Branches 17683 17730 +47
============================================
+ Hits 111935 112584 +649
+ Misses 33389 33174 -215
- Partials 9015 9034 +19
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/25374/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/25374/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.03% <ø> (-0.01%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/25374/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `22.51% <ø> (?)` | |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/25374/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.70% <ø> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 181 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/25374/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix thread leaks in ClientDeduplicationFailureTest and RackAwareTest [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #25374:
URL: https://github.com/apache/pulsar/pull/25374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org