You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/03/27 00:08:09 UTC

[GitHub] sijie commented on a change in pull request #1447: Send Log statements to log Topic for Java Functions

sijie commented on a change in pull request #1447: Send Log statements to log Topic for Java Functions
URL: https://github.com/apache/incubator-pulsar/pull/1447#discussion_r177271917
 
 

 ##########
 File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
 ##########
 @@ -262,10 +268,12 @@ public void run() {
                 }
                 long processAt = System.currentTimeMillis();
                 stats.incrementProcessed(processAt);
+                addLogTopicHandler();
 
 Review comment:
   this seems to be done at per message?
   
   Can we configure the log handler at the beginning of the instance and remove it at the end?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services