You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Hyunsik Choi <hy...@apache.org> on 2014/07/28 04:28:43 UTC
Re: Review Request 20852: ALTER TABLE ADD/DROP PARTITION statement
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20852/#review48823
-----------------------------------------------------------
Any progress?
- Hyunsik Choi
On May 29, 2014, 6:30 a.m., Alvin Henrick wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20852/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 6:30 a.m.)
>
>
> Review request for Tajo and Hyunsik Choi.
>
>
> Bugs: TAJO-744
> https://issues.apache.org/jira/browse/TAJO-744
>
>
> Repository: tajo
>
>
> Description
> -------
>
> TAJO-744 review request. The work is still in progress but wanted to get some feedback.
>
>
> Diffs
> -----
>
> tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTable.java 0f56bc2
> tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTableOpType.java 67b28a2
> tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnPredicatePartition.java PRE-CREATION
> tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java f60b571
> tajo-algebra/src/main/java/org/apache/tajo/algebra/JsonHelper.java 7d853d6
> tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionMethodDescExpr.java PRE-CREATION
> tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionType.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java fcaa4c3
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableType.java 0b7639c
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java d823f25
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 85ea516
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/PartitionPredicate.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/PartitionPredicateSchema.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionPredicateMethodDesc.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto e70ed2b
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java 7924af1
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 0d22486
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java 5de9633
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java d6f9fc3
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java ca99160
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java 849afc8
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/partition_methods.sql 4ad4c60
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/partition_methods_store.sql PRE-CREATION
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_methods.sql 060c4c8
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_methods_store.sql PRE-CREATION
> tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java 453a54d
> tajo-core/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 0076794
> tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java e7de8f6
> tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java 0780d4f
> tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/AlterTableNode.java 76a47d0
> tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java 3b81ce2
> tajo-core/src/test/java/org/apache/tajo/engine/parser/TestSQLAnalyzer.java 2010502
> tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java 57d8b32
> tajo-core/src/test/resources/queries/TestAlterTable/alter_table_add_partition_ddl.sql PRE-CREATION
> tajo-core/src/test/resources/queries/TestAlterTable/alter_table_drop_partition_ddl.sql PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20852/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alvin Henrick
>
>
Re: Review Request 20852: ALTER TABLE ADD/DROP PARTITION statement
Posted by Hyunsik Choi <hy...@apache.org>.
> On July 28, 2014, 11:28 a.m., Hyunsik Choi wrote:
> > Any progress?
>
> Alvin Henrick wrote:
> Hi Hyusik ,
> I truly apologize.I am not making any progress.
> I have got this new project which requires Monday to Friday traveling.
>
> I am trying to get a local project and hopefully will be back in action soon.
>
> If you think it is getting delayed I will be more than happy to assign it someone in the team.
>
>
> Thanks!
> Warm Regards,
> Alvin.
Hi Alvin,
No problem. Recently, I've also been busy due to adopting Tajo to production clusters in some company.
This work is necessary, but the current partition system work well in real clusters. So, we don't need to hasten it.
Best regards,
Hyunsik
- Hyunsik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20852/#review48823
-----------------------------------------------------------
On May 29, 2014, 6:30 a.m., Alvin Henrick wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20852/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 6:30 a.m.)
>
>
> Review request for Tajo and Hyunsik Choi.
>
>
> Bugs: TAJO-744
> https://issues.apache.org/jira/browse/TAJO-744
>
>
> Repository: tajo
>
>
> Description
> -------
>
> TAJO-744 review request. The work is still in progress but wanted to get some feedback.
>
>
> Diffs
> -----
>
> tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTable.java 0f56bc2
> tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTableOpType.java 67b28a2
> tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnPredicatePartition.java PRE-CREATION
> tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java f60b571
> tajo-algebra/src/main/java/org/apache/tajo/algebra/JsonHelper.java 7d853d6
> tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionMethodDescExpr.java PRE-CREATION
> tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionType.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java fcaa4c3
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableType.java 0b7639c
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java d823f25
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 85ea516
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/PartitionPredicate.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/PartitionPredicateSchema.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionPredicateMethodDesc.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto e70ed2b
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java 7924af1
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 0d22486
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java 5de9633
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java d6f9fc3
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java ca99160
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java 849afc8
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/partition_methods.sql 4ad4c60
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/partition_methods_store.sql PRE-CREATION
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_methods.sql 060c4c8
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_methods_store.sql PRE-CREATION
> tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java 453a54d
> tajo-core/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 0076794
> tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java e7de8f6
> tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java 0780d4f
> tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/AlterTableNode.java 76a47d0
> tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java 3b81ce2
> tajo-core/src/test/java/org/apache/tajo/engine/parser/TestSQLAnalyzer.java 2010502
> tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java 57d8b32
> tajo-core/src/test/resources/queries/TestAlterTable/alter_table_add_partition_ddl.sql PRE-CREATION
> tajo-core/src/test/resources/queries/TestAlterTable/alter_table_drop_partition_ddl.sql PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20852/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alvin Henrick
>
>
Re: Review Request 20852: ALTER TABLE ADD/DROP PARTITION statement
Posted by Alvin Henrick <ah...@apache.org>.
> On July 28, 2014, 2:28 a.m., Hyunsik Choi wrote:
> > Any progress?
Hi Hyusik ,
I truly apologize.I am not making any progress.
I have got this new project which requires Monday to Friday traveling.
I am trying to get a local project and hopefully will be back in action soon.
If you think it is getting delayed I will be more than happy to assign it someone in the team.
Thanks!
Warm Regards,
Alvin.
- Alvin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20852/#review48823
-----------------------------------------------------------
On May 28, 2014, 9:30 p.m., Alvin Henrick wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20852/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 9:30 p.m.)
>
>
> Review request for Tajo and Hyunsik Choi.
>
>
> Bugs: TAJO-744
> https://issues.apache.org/jira/browse/TAJO-744
>
>
> Repository: tajo
>
>
> Description
> -------
>
> TAJO-744 review request. The work is still in progress but wanted to get some feedback.
>
>
> Diffs
> -----
>
> tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTable.java 0f56bc2
> tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTableOpType.java 67b28a2
> tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnPredicatePartition.java PRE-CREATION
> tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java f60b571
> tajo-algebra/src/main/java/org/apache/tajo/algebra/JsonHelper.java 7d853d6
> tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionMethodDescExpr.java PRE-CREATION
> tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionType.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java fcaa4c3
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableType.java 0b7639c
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java d823f25
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 85ea516
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/PartitionPredicate.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/PartitionPredicateSchema.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionPredicateMethodDesc.java PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto e70ed2b
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java 7924af1
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 0d22486
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java 5de9633
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java d6f9fc3
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java ca99160
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java 849afc8
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/partition_methods.sql 4ad4c60
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/partition_methods_store.sql PRE-CREATION
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_methods.sql 060c4c8
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_methods_store.sql PRE-CREATION
> tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java 453a54d
> tajo-core/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 0076794
> tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java e7de8f6
> tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java 0780d4f
> tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/AlterTableNode.java 76a47d0
> tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java 3b81ce2
> tajo-core/src/test/java/org/apache/tajo/engine/parser/TestSQLAnalyzer.java 2010502
> tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java 57d8b32
> tajo-core/src/test/resources/queries/TestAlterTable/alter_table_add_partition_ddl.sql PRE-CREATION
> tajo-core/src/test/resources/queries/TestAlterTable/alter_table_drop_partition_ddl.sql PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20852/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alvin Henrick
>
>