You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "legendtkl (via GitHub)" <gi...@apache.org> on 2023/03/30 10:35:34 UTC
[GitHub] [incubator-paimon] legendtkl opened a new pull request, #775: [flink] support tables inherit not built-in configurations from catalog
legendtkl opened a new pull request, #775:
URL: https://github.com/apache/incubator-paimon/pull/775
### Purpose
issue ref: https://github.com/apache/incubator-paimon/issues/754
### Tests
Add test cases in ITCase.
Now we lack the UT for the catalog, but there's already an issue https://github.com/apache/incubator-paimon/issues/751 to track this. So I add the test cases in ITCase temporarily.
### API and Format
no
### Documentation
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] legendtkl commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1490412975
hi, @JingsongLi @FangYongs , would you help review this?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] FangYongs commented on a diff in pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on code in PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#discussion_r1153915882
##########
paimon-common/src/main/java/org/apache/paimon/options/CatalogOptions.java:
##########
@@ -75,4 +77,18 @@ public class CatalogOptions {
.defaultValue(true)
.withDescription(
"Allow to fallback to hadoop File IO when no file io found for the scheme.");
+
+ public static final Set<String> PAIMON_CATALOG_OPTIONS =
+ new HashSet<String>() {
+ {
+ add(WAREHOUSE.key());
+ add(METASTORE.key());
+ add(URI.key());
+ add(TABLE_TYPE.key());
+ add(LOCK_ENABLED.key());
+ add(LOCK_CHECK_MAX_SLEEP.key());
+ add(LOCK_ACQUIRE_TIMEOUT.key());
+ add(FS_ALLOW_HADOOP_FALLBACK.key());
+ }
Review Comment:
Can we get all fields from `CatalogOptions` instead of add them manually? Such as `FlinkConnectorOptions#getOptions`, we can add a tool class for them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] sonarcloud[bot] commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1499978160
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-paimon&pullRequest=775)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL) [34 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775&metric=new_duplicated_lines_density&view=list) [1.8% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] legendtkl commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1503073048
> Hi @legendtkl , can you document this? Maybe in `create catalog` page?
Yes, good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] legendtkl commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1492835102
/jdk11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] legendtkl closed pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl closed pull request #775: [flink] support tables inherit not built-in configurations from catalog
URL: https://github.com/apache/incubator-paimon/pull/775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#discussion_r1162668237
##########
docs/content/how-to/creating-catalogs.md:
##########
@@ -113,6 +126,8 @@ spark-sql ... \
--conf spark.sql.catalog.paimon.uri=thrift://<hive-metastore-host-name>:<port>
```
+You can also define any default properties with the prefix `spark.sql.catalog.paimon.table_default.` configuration for tables as above `Catalog with Filesystem Metastore`.
Review Comment:
`table_default` works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] legendtkl commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1491246816
> Thanks @legendtkl for the contribution.
>
> I wonder if I need a prefix to identify this as the default parameter for table. Is there a similar example in the industry?
@JingsongLi
Yes, this is a good idea to make the behavior more determinate.
The flink kafka connector properties follow this convention to use `properties.` prefix for any kafka configuration. https://nightlies.apache.org/flink/flink-docs-release-1.17/docs/connectors/table/kafka/#properties. Let's do it in the same way.
What about the prefix value? "table.properties.", or "global.properties", or anything else? Do you have any good idea about this?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] sonarcloud[bot] commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1500086718
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-paimon&pullRequest=775)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL) [42 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775&metric=new_duplicated_lines_density&view=list) [1.8% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] legendtkl closed pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl closed pull request #775: [flink] support tables inherit not built-in configurations from catalog
URL: https://github.com/apache/incubator-paimon/pull/775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1495581516
Maybe Maybe we can introduce `table-default.` for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] sonarcloud[bot] commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1500787236
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-paimon&pullRequest=775)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL) [42 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775&metric=new_duplicated_lines_density&view=list) [1.8% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] legendtkl commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1493596647
> > > Thanks @legendtkl for the contribution.
> > > I wonder if I need a prefix to identify this as the default parameter for table. Is there a similar example in the industry?
> >
> >
> > @JingsongLi
> > Yes, this is a good idea to make the behavior more determinate.
> > The flink kafka connector properties follow this convention to use `properties.` prefix for any kafka configuration. https://nightlies.apache.org/flink/flink-docs-release-1.17/docs/connectors/table/kafka/#properties. Let's do it in the same way.
> > What about the prefix value? "table.properties.", or "global.properties", or anything else? Do you have any good idea about this?
> > Thanks.
>
> Thanks, let me take a look to others.
Ping me if you have any good idea or update. @JingsongLi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#discussion_r1162246259
##########
paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java:
##########
@@ -95,6 +116,12 @@ protected void checkNotSystemTable(Identifier identifier, String method) {
}
}
+ protected void copyTableDefaultOptions(Map<String, String> options) {
+ tableDefaultOptions
Review Comment:
NIT: `tableDefaultOptions.forEach`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] sonarcloud[bot] commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1499878665
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-paimon&pullRequest=775)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL) [28 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775&metric=new_duplicated_lines_density&view=list) [2.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#discussion_r1159249557
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/FlinkCatalog.java:
##########
@@ -210,11 +212,31 @@ public void createTable(ObjectPath tablePath, CatalogBaseTable table, boolean ig
}
// remove table path
- String specific = options.remove(PATH.key());
- if (specific != null) {
- catalogTable = catalogTable.copy(options);
+ options.remove(PATH.key());
+
+ // Put Paimon catalog global options into table options
+ // ref https://github.com/apache/incubator-paimon/issues/754
+ if (catalog instanceof org.apache.paimon.catalog.AbstractCatalog) {
Review Comment:
We should put this into `AbstractCatalog`. Other engines should have this capability too.
In `AbstractCatalog`:
```
protected AbstractCatalog(FileIO fileIO, Map<String, String> catalogOptions) {
this.fileIO = fileIO;
this.tableDefaultOptions = ...;
}
```
And copy Schema in `createTable` with table default options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#discussion_r1160392484
##########
paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java:
##########
@@ -95,6 +116,12 @@ protected void checkNotSystemTable(Identifier identifier, String method) {
}
}
+ protected void copyTableDefaultOptions(Map<String, String> options) {
+ tableDefaultOptions.keySet().stream()
+ .filter(key -> !options.containsKey(key))
Review Comment:
`putIfAbsent`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1491231869
Thanks @legendtkl for the contribution.
I wonder if I need a prefix to identify this as the default parameter for table.
Is there a similar example in the industry?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] FangYongs commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "FangYongs (via GitHub)" <gi...@apache.org>.
FangYongs commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1491245919
@JingsongLi @legendtkl Should we need specific prefix for different components? What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1491768641
> > Thanks @legendtkl for the contribution.
> > I wonder if I need a prefix to identify this as the default parameter for table. Is there a similar example in the industry?
>
> @JingsongLi
>
> Yes, this is a good idea to make the behavior more determinate.
>
> The flink kafka connector properties follow this convention to use `properties.` prefix for any kafka configuration. https://nightlies.apache.org/flink/flink-docs-release-1.17/docs/connectors/table/kafka/#properties. Let's do it in the same way.
>
> What about the prefix value? "table.properties.", or "global.properties", or anything else? Do you have any good idea about this?
>
> Thanks.
Thanks, let me take a look to others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1495582508
https://cloud.google.com/bigquery/docs/default-configuration also has default options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] sonarcloud[bot] commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1500011921
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-paimon&pullRequest=775)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL) [42 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-paimon&pullRequest=775&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775&metric=new_duplicated_lines_density&view=list) [1.8% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-paimon&pullRequest=775&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] legendtkl closed pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "legendtkl (via GitHub)" <gi...@apache.org>.
legendtkl closed pull request #775: [flink] support tables inherit not built-in configurations from catalog
URL: https://github.com/apache/incubator-paimon/pull/775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #775: [flink] support tables inherit not built-in configurations from catalog
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #775:
URL: https://github.com/apache/incubator-paimon/pull/775#issuecomment-1499897131
Please rebase master, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org